Closed
Bug 870612
Opened 12 years ago
Closed 12 years ago
[MMS] Composer. "TO" field has a wrong shape between itself and the header
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:leo+, b2g18 verified)
People
(Reporter: vicky, Assigned: rwaldron)
References
Details
Attachments
(3 files, 1 obsolete file)
There's an odd shape generated by mistake between the 2 elements.
Se attachment that illustrates it.
Reporter | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → waldron.rick
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #747705 -
Flags: review?(fbsc)
Comment 3•12 years ago
|
||
Please, create a PR to Bocoup branch for reviewing the code. Thanks!
Assignee | ||
Comment 4•12 years ago
|
||
"bocoup" doesn't appear as one of the options to make a PR on github. This isn't really a "review", it's just restoring the previous styles... those styles were _already_ reviewed
Assignee | ||
Comment 5•12 years ago
|
||
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #747705 -
Attachment is obsolete: true
Attachment #747705 -
Flags: review?(fbsc)
Attachment #748042 -
Flags: review?(fbsc)
Comment 7•12 years ago
|
||
Comment 8•12 years ago
|
||
Small regression due to an old style neede to be removed. Having the 'white' background color was hiding us the problem. Solution is here https://github.com/bocoup/gaia/pull/6#issuecomment-17737883. Please fix it.
Comment 9•12 years ago
|
||
Comment on attachment 748042 [details]
Fix for 870612
Update commit name with ' r=borjasalguero' and it's ready to merge in DEV-Branch.
Attachment #748042 -
Flags: review?(fbsc) → review+
Updated•12 years ago
|
Whiteboard: [NO_UPLIFT] dev-branch
Comment 10•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: [NO_UPLIFT] dev-branch → [NO_UPLIFT]
Updated•12 years ago
|
Whiteboard: [NO_UPLIFT]
Updated•12 years ago
|
blocking-b2g: --- → leo+
Comment 11•12 years ago
|
||
I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with:
git checkout v1-train
git cherry-pick -x 1968e92747c272f95a1adde8014966e550cc5492
<RESOLVE MERGE CONFLICTS>
git commit
Flags: needinfo?(waldron.rick)
Comment 12•12 years ago
|
||
Flags: needinfo?(waldron.rick) → needinfo?(jhford)
Comment 13•12 years ago
|
||
v1-train: 334c0e934d78cff74d27dd553081a442c759d6e2
status-b2g18:
--- → fixed
Flags: needinfo?(jhford)
Comment 14•11 years ago
|
||
Issue no longer repros. on the Leo device
Build ID: 20130808041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1433d653b701
Gaia: 5cb67ea419b0a642ea11b6c8f93c3ee50318e90a
Platform Version: 18.1
TO" field has no space showing between itself and the header.
You need to log in
before you can comment on or make changes to this bug.
Description
•