Closed Bug 870747 Opened 11 years ago Closed 11 years ago

Move value selector BB files out of system app

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g18?)

RESOLVED FIXED
Tracking Status
b2g18 ? ---

People

(Reporter: mihai, Assigned: basiclines)

References

Details

Attachments

(1 file)

The value selector building blocks (cf. https://wiki.mozilla.org/Gaia/Design/BuildingBlocks#Value_Selector) are decentralized across different apps, their main iteration being located in the System app. The following should be moved to shared/style and apps depending on this updated: apps/system/style/value_selector/* apps/system/style/bb/ (which also includes date_picker and time_picker) On a high level search through apps, copies of value_selector.css reside in (Note: this list might be incomplete): apps/bluetooth/style/bb/value_selector.css apps/email/style/value_selector.css ** apps/system/style/bb/value_selector.css ** apps/system/style/value_selector/value_selector.css
Blocks: 837089
It seems that value selector also has some js code in apps/system/js/value_selector/, I suppose this would also need to be moved to shared/
I think the only needed files to be shared are just the .css files. value_selector .js files should be keept in system folder as the .css are officially BUilding Blocks
Blocks: 891296
Attached file PR (deleted) —
Attachment #788882 - Flags: review?(timdream)
Attachment #788882 - Flags: review?(alive)
Assignee: nobody → igonzaleznicolas
Have you manually tested all the dialog to see if it works still?
Sure, i've tested all value pickers (time, date and value) manually from calendar app and from ui test app all the confirm/dialogs/pickers available. I don't know if there is other ones to manually test from other applications.
Comment on attachment 788882 [details] PR Thanks!
Attachment #788882 - Flags: review?(timdream) → feedback+
Comment on attachment 788882 [details] PR r=me, thanks.
Attachment #788882 - Flags: review?(alive) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: