Closed
Bug 870788
Opened 12 years ago
Closed 9 years ago
reflow-on-zoom should reflow each subdocument as a separate event
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: jwir3, Assigned: jwir3)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Currently, when we perform reflow-on-zoom, pages that have a large number (>2) of subdocuments (e.g. cnn.com articles) will take longer to reflow than pages that do not have this attribute. Because this causes problems with responsiveness, we should separate the reflow of each of these documents into individual events so that UI events can be processed in between each of these. Moreover, the root document should be reflown first, which will (hopefully) improve perceived performance in the majority of cases.
I split this off from bug 836565, since it's easier to track as a separate bug.
Assignee | ||
Comment 1•12 years ago
|
||
This patch makes the processing of reflow-on-zoom (max line box width) changes asynchronous for sub-document viewers. The document viewer class maintains a static queue of events to be processed. When a new request for changing the max line box width comes in, if the max line box width requested is different from the current max line box width for a given document viewer/pres shell, then it will enqueue a new request to change the max line box width for this document viewer.
The first request for a given document is always processed immediately, and then this function dispatches the next request in the queue to the main thread, to be processed asynchronously.
Attachment #752497 -
Flags: review?(dbaron)
Assignee | ||
Comment 2•12 years ago
|
||
Also, I'm in the process of writing a robocop test for reflow-on-zoom, but I'll post it as a separate patch.
Comment 3•11 years ago
|
||
Do we still want this? (I recall some suggestion that we didn't, but I'm not sure.)
Flags: needinfo?(sjohnson)
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to David Baron [:dbaron] (needinfo? me) from comment #3)
> Do we still want this? (I recall some suggestion that we didn't, but I'm not
> sure.)
I think we can probably skip this. It looks like reflow-on-zoom is performing fairly well without it, so we should maybe avoid adding the complexity.
Flags: needinfo?(sjohnson)
Comment 5•11 years ago
|
||
Comment on attachment 752497 [details] [diff] [review]
b870788
ok, cancelling review, then
Attachment #752497 -
Flags: review?(dbaron)
Comment 6•10 years ago
|
||
Mass change to move Firefox for Android::Readability bugs to block bug 1129033. Filter on readability-mass-move.
Blocks: 1129033
Component: Readability → General
Comment 7•9 years ago
|
||
This code was removed.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•