Closed
Bug 870868
Opened 12 years ago
Closed 12 years ago
Freeze the second number of the UA Gecko version at zero
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox23+ fixed, firefox24+ fixed)
RESOLVED
FIXED
mozilla24
People
(Reporter: akeybl, Assigned: dao)
References
Details
Attachments
(1 file)
(deleted),
patch
|
glandium
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Please freeze the second number of the UA Gecko version at zero. So for instance Firefox 24.1 would show up as Firefox 24.0 in the UA.
Reporter | ||
Comment 1•12 years ago
|
||
Dao - is this something you wouldn't mind resolving?
tracking-firefox23:
--- → ?
Flags: needinfo?(dao)
Assignee | ||
Comment 2•12 years ago
|
||
Yep.
Assignee: nobody → dao
Component: General → Build Config
Flags: needinfo?(dao)
OS: Mac OS X → All
Product: Firefox → Core
Hardware: x86 → All
Version: unspecified → Trunk
Comment 3•12 years ago
|
||
To be clear, from e-mail thread I suspect alex wants a UA that also shows app UA of Firefox/N.0
However there are other products (e.g. SeaMonkey) that need that second digit to be significant (SeaMonkey/2.19 as an example)
I don't *think* that this will break us as filed, but wanted to call out my concern as-community before the patch is even attached.
Updated•12 years ago
|
status-firefox23:
--- → affected
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #748254 -
Flags: review?(mh+mozilla)
Updated•12 years ago
|
Attachment #748254 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•12 years ago
|
||
Keywords: checkin-needed
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 748254 [details] [diff] [review]
patch
[Approval Request Comment]
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #748254 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
status-firefox24:
--- → fixed
tracking-firefox24:
--- → +
Updated•12 years ago
|
Attachment #748254 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 8•12 years ago
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•