Ta-da! Builds locally, we'll see if all platforms like it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd75aef18bc5

Comment on attachment 8593001 [details] [diff] [review] move DIST_FILES to moz.build Review of attachment 8593001 [details] [diff] [review]: ----------------------------------------------------------------- ::: python/mozbuild/mozbuild/backend/recursivemake.py @@ +559,5 @@ > elif isinstance(obj, FinalTargetFiles): > self._process_final_target_files(obj, obj.files, obj.target) > + > + elif isinstance(obj, DistFiles): > + # We'd like to install these via manifests as preprocessed files. File a bug to do that? @@ +565,5 @@ > + # some Makefiles, so for now we just pass them through to the > + # underlying Makefile.in. > + for f in obj.files: > + backend_file.write('DIST_FILES += %s\n' % f) > + ws ::: python/mozbuild/mozbuild/test/backend/test_recursivemake.py @@ +640,5 @@ > + ] > + > + found = [str for str in lines if str.startswith('DIST_FILES')] > + self.assertEqual(found, expected) > + ws

Comment on attachment 8593001 [details] [diff] [review] move DIST_FILES to moz.build Nothing to add over #c2, but please address those!

I guess we should disallow people from writing DIST_FILES in Makefile.ins now? How do we do that?

Looks like the list is in recursivemake.py now: http://mxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/backend/recursivemake.py#71