Closed Bug 870892 Opened 12 years ago Closed 12 years ago

[MMS] [UX] Thread list. The attachment icon is croppped

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: vicky, Assigned: greg)

References

Details

(Keywords: regression)

Attachments

(3 files)

screenshot with error
(deleted), image/png
Details
Screenshots that show how "unread" changes rendering
(deleted), image/png
Details
Pull Request
(deleted), patch
gnarf
: review+
julienw
: review+
bajaj
: approval-mozilla-b2g18+
Details | Diff | Splinter Review
Attached image screenshot with error (deleted) —
The attachment icon is cropped in the threads list view-
Depends on: 840055
Depends on: 862311
Blocks: 872514
blocking-b2g: --- → tef?
tef? is to block for 1.0.1 releases and MMS is not part of that release, I am removing the nomination, not sure what flag/version you want to use here.
blocking-b2g: tef? → ---
Can you confirm this has been fixed or needs additional attention?
Flags: needinfo?
Assignee: nobody → greg
Looks like this was fixed! Tested in nightly as well as device
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?
Resolution: --- → WORKSFORME
Some times the icon is cropped, sometimes you can see a repetition in the right side...
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
:borjasalguero if it is an inconsistant issue can you please provide steps to reproduce. I cannot reproduce and therefor cannot fix.
Flags: needinfo?(fbsc)
Greg, I can only reproduce it on the device. Sometimes (depending of the time text after - the time-) you will see it cropped or with a new 'attachment' icon appearing in the right side (some pixels).
Flags: needinfo?(fbsc)
:gnarf was able to reproduce and he found that this is caused by unread messages with a long enough timestamp. I'll add screenshots.
Attached patch Pull Request (deleted) — — Splinter Review
Attachment #755487 - Flags: review?(gnarf37)
Attachment #755487 - Flags: review?(felash)
Attachment #755487 - Flags: review?(fbsc)
Comment on attachment 755487 [details] [diff] [review] Pull Request r=me the new patch looks good, thanks ! don't forget to update the commit log with a more meaningful comment !
Attachment #755487 - Flags: review?(felash) → review+
master: https://github.com/mozilla-b2g/gaia/commit/267ec4ee2d3bb409584c489a0b105cb34eaf3821
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Attachment #755487 - Flags: review?(gnarf37)
Attachment #755487 - Flags: review?(fbsc)
Attachment #755487 - Flags: review+
Comment on attachment 755487 [details] [diff] [review] Pull Request [Approval Request Comment] Bug caused by (feature/regressing bug #): 862311 User impact if declined: Broken Images for Attachment Testing completed: yes Risk to taking this patch (and alternatives if risky): low, css/html changes mostly, removes a workaround in js no longer needed for mms with new css String or UUID changes made by this patch: none This fixes a bug in the attachment icon/thread list rendering we just uplifted.
Attachment #755487 - Flags: approval-mozilla-b2g18?
blocking-b2g: --- → leo?
Attachment #755487 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
blocking-b2g: leo? → leo+
Keywords: regression
John, can you please assist with the uplift?
Flags: needinfo?(jhford)
v1-train: ab890c4
status-b2g18: affected → fixed
Flags: needinfo?(jhford)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: