STR: 1. View the sidebar/library where a livemark is visibile Result: It has folder favicon. Expected: It has livemark/feed favicon. Details: Noticed that the livemark icon isn't showing for the bookmarks sidebar and the library. This is because the 'livemark' cell property is never set. http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/treeView.js#1148 says: > if (properties === undefined) { But for some containers |properties = ''| at that time, so the extra properties are never set here.

FYI SeaMonkey won't have this problem because we happened to add "title" to the list of cached properties so that we know that an empty properties string is equivalent to properties being unset. (However I have no idea which false-y value we actually have at that point.)

So, is the right fix here to change the if to be if (!properties) ?

the problem is that properties is intended to be a cache, to avoid having to rebuild it everytime (that's why we check undefined). if you just check !properties, in case it's empty (cause it has no properties) it will keep trying to rebuild an empty properties. looks like we are not invalidating this cache at some time

Not critical enough to track for upcoming releases. Would accept a low risk uplift though.

Some of my theme users are complaining that there is no RSS/feed icon on the feed links in Places.

This makes live bookmarks/feeds virtually undistinguishable from normal bookmarks folders both in the bookmarks sidebar and the library as well:considering that arguably the best native way (i.e. without addons) to look through web feeds is to read them from the sidebar and that the bookmarks toolbar is generally not used,I would consider this regression very annoying-which is compounded by the fact that-as far as I know-there's currently no addon or .css code that can fix this.

Looking at the current livemarks in the sidebar/library window, they all have the correct icon, so I believe this is WFM.