Followup work from the font-variant bug. Parsing of the 'font-synthesis' property has been implemented but the support for it within gfx code needs to be added.

I'm proposing to steal this bug, as I have some WIP here (prompted by discussion in bug 1023702). I'll post some patches shortly.

Tryserver run: https://tbpl.mozilla.org/?tree=Try&rev=c20e427ac9b3 And after fixing the Windows build failure there (thanks to copy/paste fail): https://tbpl.mozilla.org/?tree=Try&rev=11dd2fda7f98

Comment on attachment 8439854 [details] [diff] [review] part 1 - pass the font-synthesis flags down to gfxFontStyle. :::gfx/thebes/gfxFont.cpp @@ -141,16 +142,20 @@ struct gfxFontStyle { + // Whether synthetic styles are allowed + bool syntheticWeight : 1; + bool syntheticStyle : 1; Think these need to be named 'allowSynthetic...' so that it's clear this isn't saying that the weight/style *are* synthetic.

Comment on attachment 8440250 [details] [diff] [review] part 2 - support font-synthesis options through the platform-font-list backends. r+ with name change to syntheticWeight/syntheticStyle

I agree with the rename to allowSynthetic{Weight,Style}. I'd intended to do this, but forgot to do it before I posted the patches.

Comment on attachment 8439857 [details] [diff] [review] part 4 - reftests for the font-synthesis property. Hello cruel world indeed...

https://hg.mozilla.org/integration/mozilla-inbound/rev/167f170048ef https://hg.mozilla.org/integration/mozilla-inbound/rev/75ad9b0537ea https://hg.mozilla.org/integration/mozilla-inbound/rev/0211d8de9bac https://hg.mozilla.org/integration/mozilla-inbound/rev/20ef927d99c6

https://hg.mozilla.org/mozilla-central/rev/167f170048ef https://hg.mozilla.org/mozilla-central/rev/75ad9b0537ea https://hg.mozilla.org/mozilla-central/rev/0211d8de9bac https://hg.mozilla.org/mozilla-central/rev/20ef927d99c6

Can we mark this approval?/+ for 2.0 uplift?

(In reply to Stephany Wilkes from comment #14) > Can we mark this approval?/+ for 2.0 uplift? Why? Uplifting new features is extremely exceptional; they should generally ride the trains to release.

Got it. We're just gunning to get this in to fix RTL issues but it is large, needs bake time, and can ride the trains (per chat with Bhavana in IRC). Thanks David!

I don't see any MDN documentation on this feature.

Doc updated https://developer.mozilla.org/en-US/docs/Web/CSS/font-synthesis https://developer.mozilla.org/en-US/Firefox/Releases/33