Closed
Bug 871746
Opened 12 years ago
Closed 12 years ago
mozinfo.update should accept a path to a json file
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
Currently our test harnesses need to do something like this for when using the mozinfo.json generated by writemozinfo.py:
http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/runxpcshelltests.py#757
Assignee | ||
Comment 1•12 years ago
|
||
Allowing urls might be overkill and not worth adding in. Say the word and I'll remove it.
Attachment #749003 -
Flags: review?(jhammel)
Comment 2•12 years ago
|
||
Comment on attachment 749003 [details] [diff] [review]
Patch 1.0 - accept file paths/urls in mozinfo.update
looks good! except....
I don't think you want to bump the package version here. Normally, ABICT, the versionbump.py script is used subsequently to bump the version, ensure intra-mozbase compatability, tag, and release to pypi. If you want to do all of this manually, I am happy to give you an r+
Attachment #749003 -
Flags: review?(jhammel) → review-
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 749003 [details] [diff] [review]
Patch 1.0 - accept file paths/urls in mozinfo.update
https://github.com/mozilla/mozbase/commit/8f5ad2855c517eda65809d2fcf35f95dc8f11eb3
I'll need to version bump eventually, but am not in any rush. So I pushed without the version bump. Changing r- to r+
Attachment #749003 -
Flags: review- → review+
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 4•12 years ago
|
||
coolz, wfm. my concern is just ensuring the tag and pypi release are concurrent, as well as making sure we don't break internal compatibility
You need to log in
before you can comment on or make changes to this bug.
Description
•