Closed
Bug 871786
Opened 11 years ago
Closed 11 years ago
Remove KeyboardEvent classinfo
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: emk, Assigned: emk)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
This is needed because some existing event handlers expect that |instanceof KeyEvent| will return true for keyboard events.
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #749029 -
Flags: review?(bugs)
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Comment on attachment 749027 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent
I don't know how that Bindings.conf part works.
Attachment #749027 -
Flags: review?(bzbarsky)
Attachment #749027 -
Flags: review?(bugs)
Attachment #749027 -
Flags: review+
Comment 5•11 years ago
|
||
Comment on attachment 749029 [details] [diff] [review]
Remove KeyboardEvent classinfo
Could you remove key event from dom_quickstubs.qsconf
Attachment #749029 -
Flags: review?(bugs) → review+
Comment 6•11 years ago
|
||
Comment on attachment 749027 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent
This looks fine as long as there are no other implementations of KeyEvent.
Attachment #749027 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 7•11 years ago
|
||
This is more conformant to the latest spec because KeyEvent will not be inserted into KeyboardEvent's prototype chain.
Attachment #749027 -
Attachment is obsolete: true
Attachment #749487 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 8•11 years ago
|
||
patch for check-in
Attachment #749029 -
Attachment is obsolete: true
Comment 9•11 years ago
|
||
Comment on attachment 749487 [details] [diff] [review]
Separate D2E KeyEvent constants and a method from KeyboardEvent, v2
>+ 'nativeType': 'nsDOMKeyboardEvent',
You don't need that is 'concrete':False and nothing concrete inherits from the interface.
r=me with that.
Attachment #749487 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 10•11 years ago
|
||
Some .wedidl files are added despite of bug 872856. Trying to land.
https://hg.mozilla.org/integration/mozilla-inbound/rev/88a1b42e82a1
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb4696685200
Flags: in-testsuite-
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/88a1b42e82a1
https://hg.mozilla.org/mozilla-central/rev/fb4696685200
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•