I will attach a file that gets cut off when I do the smtpSend operation with the test program. - rhp

I wonder if the line is greater than 2048 bytes. I see a limit in my code where I'm reading line by line into a 2048 buffer. (If there is more data I read it again after I send the first 2048 bytes). But maybe because the end of line falls outside that 2048 bytes, things get messed up. M8.

It seems to break on this line...just after <A HREF="http: <TR><TD COLSPAN=3 ALIGN=CENTER><FONT SIZE=2 FACE=Arial COLOR="#000099"><B>Top Picks</B></FONT>&nbsp;:&nbsp;<small><A HREF="http://info.netscape.com/fwd/hom06pmal/http://webmail.netscape.com">WebMa il</A> | <A HREF="/sitecentral/index.html?cp=hom06psit">Home Pages</A> | <A HREF="/computing/download/index.html?cp=hom06pbro">Browsers</A> | <A HREF="/netcenter/smallbusiness/onlineessentials/start.html?cp=hom06pebb">eBusin ess</A> | <A HREF="http://info.netscape.com/fwd/hom06phor/http://horoscopes.netscape.com/hor oscopes/">Horoscopes</A> | <A HREF="http://info.netscape.com/fwd/hom06paim/http://www.newaol.com/aim/netscape /adb00.html">Instant Messenger</A> | <A HREF="http://info.netscape.com/fwd/hom06psha/http://shareware.netscape.com/comp uting/shareware/">Shareware</A> | <A HREF="/netcenter/personalize/index.html?cp=hom06pmyn">My&nbsp;Netscape</A> | <A HREF="/smartupdate/index.html?cp=hom06psmu">SmartUpdate</A> | <A HREF="http://info.netscape.com/fwd/hom06pcon/http://contact.netscape.com/contac t/">Contact</A> | <A HREF="http://info.netscape.com/fwd/hom06phdw/http://hwreviews.netscape.com/comp uting/hwreviews/">Hardware</A> | <A HREF="http://info.netscape.com/fwd/hom06pfdx/http://delivery.netscape.com/deliv ery/">Delivery Center</A> | <A HREF="http://info.netscape.com/fwd/hom06pcal/http://calendar.netscape.com">Cale ndar</A></small>

i'll leave this on m8 plate for now but it depends on how long it takes me to finish the necko landing to decide if I'm going to fix this for m8. I think the problem is that 2048 buffer i'm using to read a line in...

moving to m9 - scott's not going to have time to fix this before m8.

I think this bug would be cross platform since it's in the backend code, right?

I think I've got a pretty good idea what's causing this bug. I'll take a look at the fix after I land necko for mailnews.

Yes, I think so.

Moving all Mail/News Networking bugs to Mail/News Networking-Mail This may re-open previously Verified bugs due to a Bugzilla bug...if so, I will fix those bugs.

Assuming this is the same bug, at least a couple of messages have been sent in the last couple of days that have been truncated. I'm not sure why my message would be 2K (unless Ender is adding a lot of html for everything I type). But, if this is the problem, we can't really use Message Compose for Dogfood until this is fixed.

I checked in a fix for this. QA for this bug can happen a couple of ways. 1) you can run the smtp test app (Par?) using the file rich has attached. 2) you can send a message with more than 2K characters on the same line But on top of that some general smtp testing is necessary as a result of my changes. In particular 1) Try typing a line or two and inserting *multiple* blank lines followed by some more text. i.e. test test test Verify that when you send the file, we preserve the number of blank line returns you had in the file. 2) Send an email message of length > 2K 3) Send a message with an attachement. I'm listing these basic tests because my bug fix changed the heart of the code that actually sends the message to the server. I'm worried that I may have broken something else during send with these changes.

We'll try this out. I'll send out email to my group.

Without this fix, we won't be able to send attachments and MHTML messages. Jeff, are you familiar enough with the smtp code to look into this in mscott's absence? It would be good to be able to get a fix in for M9.

Yes, I'll take a look on this one.

this is actually fixed. - rhp

What were the code changes with this bug fix for jeff? I know by fixing this problem, I broke another problem (when you have blank line returns, we lost them sometimes) and found I was unable to fix one problem without breaking the other. The only way to fix both was going to be by fixing a problem in nsFileStream (the read next line method.

Just look at jefft's last checkin for the nsSmtpProtocol.cpp The change seemed minor, but maybe he didn't know the ramifications. - rhp

Peter, can you help Esther with verification on this bug? Thanks.

Verified on Win32, PPC, and Linux. Builds tested: Win32 1999-08-16-09-m9 build installed on P166 Win98 PPC 1999-08-16-08-m9 build installed on 9600/300 Mac OS 8.5.1 Linux 1999-08-16-08-m9 build installed on P200 Linux 6.0 I used a text file contained 3000 characters as my attachment. Since cut and paste was not available, I sent the message to a Nova mail account where I could verify that the text was not truncated. Seamonkey was not displaying text file inline. I verified that blank line were not lost. Look good. :)