Closed
Bug 872411
Opened 11 years ago
Closed 11 years ago
Menu items added by addons are not displayed while in new tabs if the "Don't keep activities" option is set
Categories
(Firefox for Android Graveyard :: Add-on Manager, defect)
Tracking
(firefox22 verified, firefox23 verified, firefox24 verified, fennec+)
VERIFIED
FIXED
Firefox 28
People
(Reporter: AdrianT, Assigned: rnewman)
References
Details
(Keywords: reproducible)
Attachments
(2 files)
Firefox Mobile 22 beta 1/ Nightly 24.0a1 2013-05-14
Samsung Galaxy S2 (Android 4.0.3)
Steps to reproduce:
1) Go to addons.mozilla.org and install Light Theme Switcher (This seems to work with any addon that adds entries in the menu - Quit now, Full Screen)
2) Open the menu and check that there is an entry for the addon
3) Open a new tab and load any page
4) Open the menu again
Expected results:
The entries added by the addons are displayed in the menu
Actual results:
The entries are not displayed - please see: http://youtu.be/vAx2qy7ZM54
In the logs the following error stack can be seen:
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): java.lang.SecurityException: /data/data/org.mozilla.firefox_beta/files/mozilla/aotlmc6w.default/extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}.xpi failed verification of META-INF/ZIGBERT.SF
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at java.util.jar.JarVerifier.failedVerification(JarVerifier.java:136)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at java.util.jar.JarVerifier.verifyCertificate(JarVerifier.java:305)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at java.util.jar.JarVerifier.readCertificates(JarVerifier.java:258)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at java.util.jar.JarFile.getInputStream(JarFile.java:378)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at libcore.net.url.JarURLConnectionImpl.getInputStream(JarURLConnectionImpl.java:226)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at java.net.URLConnection$DefaultContentHandler.getContent(URLConnection.java:1045)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at java.net.URLConnection.getContent(URLConnection.java:203)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at libcore.net.url.JarURLConnectionImpl.getContent(JarURLConnectionImpl.java:309)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at java.net.URL.getContent(URL.java:447)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at org.mozilla.gecko.BrowserApp$20.run(BrowserApp.java:1304)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at android.os.Handler.handleCallback(Handler.java:605)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at android.os.Handler.dispatchMessage(Handler.java:92)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at android.os.Looper.loop(Looper.java:137)
05-15 09:07:02.430 W/GeckoBrowserApp( 9903): at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:32)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): Unable to set icon
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): java.lang.SecurityException: /data/data/org.mozilla.firefox_beta/files/mozilla/aotlmc6w.default/extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}.xpi failed verification of META-INF/ZIGBERT.SF
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at java.util.jar.JarVerifier.failedVerification(JarVerifier.java:136)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at java.util.jar.JarVerifier.verifyCertificate(JarVerifier.java:305)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at java.util.jar.JarVerifier.readCertificates(JarVerifier.java:258)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at java.util.jar.JarFile.getInputStream(JarFile.java:378)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at libcore.net.url.JarURLConnectionImpl.getInputStream(JarURLConnectionImpl.java:226)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at java.net.URLConnection$DefaultContentHandler.getContent(URLConnection.java:1045)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at java.net.URLConnection.getContent(URLConnection.java:203)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at libcore.net.url.JarURLConnectionImpl.getContent(JarURLConnectionImpl.java:309)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at java.net.URL.getContent(URL.java:447)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at org.mozilla.gecko.BrowserApp$20.run(BrowserApp.java:1304)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at android.os.Handler.handleCallback(Handler.java:605)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at android.os.Handler.dispatchMessage(Handler.java:92)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at android.os.Looper.loop(Looper.java:137)
05-15 09:07:02.450 W/GeckoBrowserApp( 9903): at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:32)
Notes:
I was unable to reproduce the issue on the Samsung Galaxy Note (Android 4.0.3) or the LG Nexus 4 (Android 4.2.2)
The issue is reproducible with a new profile and after app restart
Comment 1•11 years ago
|
||
Not able to reproduce on the HTC One (Android 4.1), with Nightly nor Beta.
Comment 2•11 years ago
|
||
Sriram - Is that your add-on? Is your add-on signed?
Adrian - Does this happen with other add-ons?
Assignee: nobody → sriram
Reporter | ||
Comment 3•11 years ago
|
||
The issue was reproduced only on the Samsung Galaxy S2 (Android 4.0.3) and is reproducible with any addon that adds menu entries: Lightweight Theme Switcher, Fullscreen, QuitNow
Comment 4•11 years ago
|
||
Wes - Do you have access to a S2? Can we just wrap the code in a try/catch to shut it up?
Assignee: sriram → wjohnston
tracking-fennec: ? → 22+
Reporter | ||
Comment 6•11 years ago
|
||
At one point someone set the option for "Don't keep activities" to ON on our S2 device and nobody checked for it. This was logged in the same timeframe as bug 876689 and bug 878721 so I made a few tests. The cause of this is the "Don't keep activities" option, the issue is also reproducible on other devices like the LG Nexus 4 (Android 4.2.2), the logs look different but on all devices the behavior of the UI is the same: the menu items added by addons are not displayed if you open an extra tab. I will be also editing the title to reflect this.
Reporter | ||
Updated•11 years ago
|
Summary: Verification of META-INF/ZIGBERT.SF fails on the Samsung Galaxy S2 for Add-ons → Menu items added by addons are not displayed while in new tabs if the "Don't keep activities" option is set
Updated•11 years ago
|
tracking-fennec: ? → +
Comment 9•11 years ago
|
||
Not looking at this. We store these menuitems in the menu itself, so fixing this is a bit of work.
Assignee: wjohnston → nobody
Flags: needinfo?(wjohnston)
Comment 10•11 years ago
|
||
I get a number of support requests from users of my add-ons (Phony, Full Screen Mobile) that might be related to this.
Assignee | ||
Comment 11•11 years ago
|
||
Did I fix this in Bug 936756 Part 3?
Keywords: qawanted
Hardware: ARM → All
Comment 12•11 years ago
|
||
Maybe?
This works for me on trunk.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Comment 13•11 years ago
|
||
Marking as fixed by Bug 936756. The change in that bug causes added menu items to be persisted independent of the lifespan of the menu itself.
Depends on: 936756
Resolution: WORKSFORME → FIXED
Updated•11 years ago
|
Assignee: nobody → rnewman
Target Milestone: --- → Firefox 28
Updated•11 years ago
|
Flags: needinfo?(mgmg007.kmm)
Updated•11 years ago
|
Updated•11 years ago
|
blocking-b2g: koi? → ---
tracking-firefox30:
? → ---
Comment 14•10 years ago
|
||
Verified as fixed on
Builds: Nightly (2013-05-14) and Nightly (2014-05-26)
Device: Alcatel One Touch (Android 4.1.2)
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•