UX have decided that we will no longer be hiding chrome for content pages like about:addons and the australis team are removing functionality for it. So I guess we need to follow suit and deprecate the addon-page module. Thankfully this is easy, addon-page has no API as such, we just need to make requiring it a no-op (with a deprecation message) and we're done. Oh and remove the tests for it.

No API, for sure, but it offers the capability to create a tab without the Awesome Bar, Search Bar and Bookmarks Toolbar which is perfect to display some information on add-on install. These capabilities are not possible using tabs.open or I am missed something...

(In reply to Marc Chevrier from comment #1) > No API, for sure, but it offers the capability to create a tab without the > Awesome Bar, Search Bar and Bookmarks Toolbar which is perfect to display > some information on add-on install. > > These capabilities are not possible using tabs.open or I am missed > something... You aren't missing anything. The problem is that with the new australis theme that is coming for Firefox this would mean hiding critical pieces of Firefox's UI, like the main menu.

I understand your concerns but is it planned to offer some alternative way to create a tab with unwanted elements ? For example, it will be perfect to extend tabs.open with options specifying which elements must be displayed or hidden.

(In reply to Marc Chevrier from comment #3) > I understand your concerns but is it planned to offer some alternative way > to create a tab with unwanted elements ? > > For example, it will be perfect to extend tabs.open with options specifying > which elements must be displayed or hidden. I'm not sure I really see a sane way to do that, even if you hide say the location bar it doesn't gain you any screen real estate and at that point is there any reason to do it?

The idea is to be able to display, in a tab, an informational message coming from an html which is part of the add-on internals so displaying url of bookmarks make no sense in this case.

Marc, if hiding pieces of the UI is important to you, you should file a new bug for that.

Pointer to Github pull-request

Comment on attachment 755791 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1013 As discussed, I just added the deprecation message and keep the functionality, in order to give time to the developers to deal with it. Maybe we could also uplift to Firefox 23. I was wondering: Do we keep this bug open until we remove the functionality, or we'll open a new bug for that?

(In reply to Matteo Ferretti [:matteo] [:zer0] from comment #8) > Comment on attachment 755791 [details] > Pointer to Github pull request: > https://github.com/mozilla/addon-sdk/pull/1013 > > As discussed, I just added the deprecation message and keep the > functionality, in order to give time to the developers to deal with it. > Maybe we could also uplift to Firefox 23. > > I was wondering: Do we keep this bug open until we remove the functionality, > or we'll open a new bug for that? Apologies for the driveby: on the UX branch, these tests currently fail, all the time, because the functionality is already gone. Would it be possible to remove the tests and only check the deprecation message?

(In reply to :Gijs Kruitbosch from comment #9) > (In reply to Matteo Ferretti [:matteo] [:zer0] from comment #8) > > Comment on attachment 755791 [details] > > Pointer to Github pull request: > > https://github.com/mozilla/addon-sdk/pull/1013 > > > > As discussed, I just added the deprecation message and keep the > > functionality, in order to give time to the developers to deal with it. > > Maybe we could also uplift to Firefox 23. > > > > I was wondering: Do we keep this bug open until we remove the functionality, > > or we'll open a new bug for that? > > Apologies for the driveby: on the UX branch, these tests currently fail, all > the time, because the functionality is already gone. Would it be possible to > remove the tests and only check the deprecation message? You can do that on your UX branch if you like. Given that the functionality still exists in m-c and that is where we merge to we will be keeping the tests around until we remove the functionality

Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/759c4a533457f2ff22b401b691d0173ce6d1dc74 Bug 873102 - Deprecate the addon-page module - Added deprecation message - Update unit test to check deprecation message https://github.com/mozilla/addon-sdk/commit/338ffdbadb7e5aef1cb8c0d65e6d9886b34f61f8 Merge pull request #1013 from ZER0/addon-page/873102 fix Bug 873102 - Deprecate the addon-page module r=@Mossop

Commits pushed to integration at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/759c4a533457f2ff22b401b691d0173ce6d1dc74 Bug 873102 - Deprecate the addon-page module https://github.com/mozilla/addon-sdk/commit/338ffdbadb7e5aef1cb8c0d65e6d9886b34f61f8 Merge pull request #1013 from ZER0/addon-page/873102