Closed
Bug 873134
Opened 11 years ago
Closed 11 years ago
Notify install success before starting to download package
Categories
(Core Graveyard :: DOM: Apps, defect)
Core Graveyard
DOM: Apps
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
mozIDOMApplicationRegistry2.installPackage is supposed to trigger the DOMRequest.onsuccess callback and mozIDOMApplicationMgmt.oninstall event *before* starting to download the package of the app. We are currently not doing it :(.
To be honest, I don't even know how is this currently working for Gaia :\
Updated•11 years ago
|
Blocks: b2g-apps-v1-next
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 1•11 years ago
|
||
Actually, I'd like to know how Gaia is working before nominating for tef+
blocking-b2g: tef? → ---
Assignee | ||
Comment 2•11 years ago
|
||
Updated•11 years ago
|
Blocks: b2g-apps-v1-next
Comment 4•11 years ago
|
||
Well, I'm quite sure it works in gaia :)
but I follow your reasoning, Fabrice should know better.
Flags: needinfo?(felash) → needinfo?(fabrice)
Assignee | ||
Comment 5•11 years ago
|
||
So it seems that this is working on b2g18 but not in m-i, birch or m-c. The reason seems to be Bug 856131
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #750538 -
Attachment is obsolete: true
Attachment #750992 -
Flags: review?(fabrice)
Attachment #750992 -
Flags: feedback?(jhugman)
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(fabrice)
Assignee | ||
Comment 7•11 years ago
|
||
With the attached patch we notify via 'mgmt.oninstall' and 'DOMRequest.onsuccess' as soon as the app is stored in the apps registry for both, hosted and packaged apps. This way consumers of the mgmt API will receive the app object along with the 'mgmt.oninstall' event and will be able to listen to the package download events as expected.
James, I am not sure if you expect 'aInstallSuccessCallback' to be fired along with the 'oninstall' and the 'DOMRequest.onsuccess' events or once the package download is completed.
Comment 8•11 years ago
|
||
aInstallSuccessCallback is supposed to be called after the end of the download.
Assignee | ||
Comment 9•11 years ago
|
||
Ok, thanks James. That's the way the attached patch works.
Updated•11 years ago
|
Attachment #750992 -
Flags: review?(fabrice)
Attachment #750992 -
Flags: review+
Attachment #750992 -
Flags: feedback?(jhugman)
Updated•11 years ago
|
Keywords: regression
Assignee | ||
Comment 10•11 years ago
|
||
Comment 11•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Updated•11 years ago
|
No longer blocks: b2g-apps-v1-next
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•