Closed
Bug 873326
Opened 12 years ago
Closed 12 years ago
Small tweaks to category header
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wenzel, Unassigned)
References
Details
(Whiteboard: [fireplace] p=1)
Attachments
(2 files, 1 obsolete file)
1) The new Fireplace category dropdown header keeps its focus when clicked, so it remains blue and with a dotted border. Instead, it should probably blur() when clicked. Screenshot attached.
2) The same header opens the category dropdown when clicked, but the arrow remains downward-pointing. Instead, it should turn into a caret ^ because clicking it again will *close* the categories.
Comment 1•12 years ago
|
||
Fred, you are good. I have these TODOs in an Evernote, in addition to on mobile the checkmark should be visible on the new category upon touch. I'm impressed :)
Blocks: 859511
Whiteboard: [fireplace] p=1
Comment 2•12 years ago
|
||
Just as mentioned on github, followup here:
There are 2 things that seems to be wrong(atleast to me):
1. The Categories Menu items are made to listen 2 events mousedown and mouse click well the former one make a category selected even though i would have accidentally just pressed the mouse and then moved it away.
Could have a mouseup handler if you are insisting to keep it, a flag(element attribute as flag) or something that tells that whether it was a click or just a mouse up-down game.
2. Whenever i click categories[the drop down list], clicking out somewhere should have made it disappear or even a Esc key handler would be great.
Updated•12 years ago
|
Priority: -- → P3
Comment 3•12 years ago
|
||
Obsolete, of no interest, however you can see what actually i meant by my comment 2 - > Point 1
Comment 4•12 years ago
|
||
Partial Patch(not including comment 2 -> Point 1, so partial)
Attachment #753108 -
Attachment is obsolete: true
Attachment #753111 -
Flags: review+
Attachment #753111 -
Flags: feedback+
Comment 5•12 years ago
|
||
We don't use Bugzilla for patches. Feel free to use GitHub to open a pull request - https://github.com/mozilla/fireplace
Thanks for contributing!
Comment 6•12 years ago
|
||
We landed the arrow flipping a while back. Woohoo!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 7•12 years ago
|
||
Lol okay we did not fix the other issues
You need to log in
before you can comment on or make changes to this bug.
Description
•