Closed
Bug 873358
Opened 11 years ago
Closed 11 years ago
textarea claims bogus trailing \n (HTML br)
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: surkov, Assigned: surkov)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
Textarea container trailing <br> element when it has not empty value lie
<textarea>h</textarea>
See bug 503838.
We just create an accessible for that br which is mapped to '\n'.
That br node is not nsGkAtoms::mozeditorbogusnode, it is nsGkAtoms::mozdirty="" node.
Assignee | ||
Updated•11 years ago
|
Blocks: getText*a11y
Assignee | ||
Comment 1•11 years ago
|
||
note, there's related bug 240933 (which seems removed all brs but the trailing one).
Comment 2•11 years ago
|
||
Not sure what you're asking for here, Alexander.
Assignee | ||
Comment 3•11 years ago
|
||
if I have <textarea>hello</textarea> then DOM looks the following way (judging by accessibility tree):
textarea
textleaf (hello)
br
that br is confusing for accessibility. Why it wasn't removed in bug 240933 and is there a reason to have it nowdays?
Comment 4•11 years ago
|
||
(In reply to comment #3)
> if I have <textarea>hello</textarea> then DOM looks the following way (judging
> by accessibility tree):
>
> textarea
> textleaf (hello)
> br
>
> that br is confusing for accessibility. Why it wasn't removed in bug 240933 and
> is there a reason to have it nowdays?
Because it's needed for caret positioning. Of course we can fix that, but we don't have anybody to do that work! Until that happens, accessibility should ignore that node.
Assignee | ||
Comment 5•11 years ago
|
||
so at accessibility layer we can just ignore any non text nodes under textarea. Is that correct?
Comment 6•11 years ago
|
||
(In reply to comment #5)
> so at accessibility layer we can just ignore any non text nodes under textarea.
> Is that correct?
This should be the only non-textnode node under textarea's anonymous div, so, yes. Although if you want to be super conservative, you could choose to only ignore trailing BRs.
Assignee | ||
Comment 7•11 years ago
|
||
Should I leave this bug open for layout part and get another one for accessibility fix?
Comment 8•11 years ago
|
||
(In reply to comment #7)
> Should I leave this bug open for layout part and get another one for
> accessibility fix?
No, we have bug 503838 on the higher level problem.
Assignee | ||
Comment 9•11 years ago
|
||
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #752682 -
Flags: review?(trev.saunders)
Comment 10•11 years ago
|
||
do you understand regressions and have plan to work on them?
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #10)
> do you understand regressions
I don't but as long as new move by words logic still works with the change then I don't worry about move by lines regressions
> and have plan to work on them?
yes
Comment 12•11 years ago
|
||
(In reply to alexander :surkov from comment #11)
> (In reply to Trevor Saunders (:tbsaunde) from comment #10)
> > do you understand regressions
>
> I don't but as long as new move by words logic still works with the change
> then I don't worry about move by lines regressions
ok
Updated•11 years ago
|
Attachment #752682 -
Flags: review?(trev.saunders) → review+
Assignee | ||
Comment 13•11 years ago
|
||
Btw, I was reported that JAWS misses textareas in vb in Aurora (Firefox 23) because it started to expose child text leaf accessibles and that was caused by bug 865997. Bug 865997 logic is expose everything as long as non textual children are presented. In this bug we prevent HTML br to appear inside textareas so this bug will be a fix for JAWS issue. We need to backport it Aurora.
Assignee | ||
Comment 14•11 years ago
|
||
Flags: in-testsuite+
Comment 15•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Comment 16•11 years ago
|
||
Note that this caused bug 875794. I will not approve a backport to 23 unless that bug is resolved and a fix tested. The alternative is to back out this bug and have FS find another solution to detecting textareas properly.
You need to log in
before you can comment on or make changes to this bug.
Description
•