Follow-up from bug 836599. Currently, our OfflineAudioContext can only run at 48KHz.

Here we go!

The try server is loving this stuff! \o/

Comment on attachment 752468 [details] [diff] [review] Part 2: Teach each AudioNodeStream about its sampling rate, and store the value inside AudioContext Review of attachment 752468 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/MediaStreamGraph.cpp @@ +989,5 @@ > + AudioNodeStream* n = mStreams[i]->AsAudioNodeStream(); > + if (n) { > + // We know that the rest of the streams will run at the same rate. > + sampleRate = n->SampleRate(); > + break; I think we should store this in the graph rather than recomputing it here. Can we avoid having to store it in all the AudioNodeStreams then?

(In reply to comment #14) > Comment on attachment 752468 [details] [diff] [review] > --> https://bugzilla.mozilla.org/attachment.cgi?id=752468 > Part 2: Teach each AudioNodeStream about its sampling rate, and store the value > inside AudioContext > > Review of attachment 752468 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: content/media/MediaStreamGraph.cpp > @@ +989,5 @@ > > + AudioNodeStream* n = mStreams[i]->AsAudioNodeStream(); > > + if (n) { > > + // We know that the rest of the streams will run at the same rate. > > + sampleRate = n->SampleRate(); > > + break; > > I think we should store this in the graph rather than recomputing it here. > > Can we avoid having to store it in all the AudioNodeStreams then? I thought about doing that, I'm not sure if it's safe to keep the assumption that all streams will run at the same sampling rate forever, but I would like to experiment with MediaStreamAudioSource/DestinationNode when they land a bit. For now I think it's more conservative to store them on AudioNodeStreams, so I'd like to proceed with this right now, and later on switch to storeing them in the graph if we decide that makes sense.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef11b35e45f1 https://hg.mozilla.org/integration/mozilla-inbound/rev/738b82a25037 https://hg.mozilla.org/integration/mozilla-inbound/rev/34b39b3d4773 https://hg.mozilla.org/integration/mozilla-inbound/rev/59f25c1db414 https://hg.mozilla.org/integration/mozilla-inbound/rev/7efdd15be9c7 https://hg.mozilla.org/integration/mozilla-inbound/rev/d34c29fe4eda https://hg.mozilla.org/integration/mozilla-inbound/rev/4c425085391c https://hg.mozilla.org/integration/mozilla-inbound/rev/a10e7a43eebf https://hg.mozilla.org/integration/mozilla-inbound/rev/0d624598cc17 https://hg.mozilla.org/integration/mozilla-inbound/rev/976545bf713e https://hg.mozilla.org/integration/mozilla-inbound/rev/670d867ff3ba

https://hg.mozilla.org/mozilla-central/rev/ef11b35e45f1 https://hg.mozilla.org/mozilla-central/rev/738b82a25037 https://hg.mozilla.org/mozilla-central/rev/34b39b3d4773 https://hg.mozilla.org/mozilla-central/rev/59f25c1db414 https://hg.mozilla.org/mozilla-central/rev/7efdd15be9c7 https://hg.mozilla.org/mozilla-central/rev/d34c29fe4eda https://hg.mozilla.org/mozilla-central/rev/4c425085391c https://hg.mozilla.org/mozilla-central/rev/a10e7a43eebf https://hg.mozilla.org/mozilla-central/rev/0d624598cc17 https://hg.mozilla.org/mozilla-central/rev/976545bf713e https://hg.mozilla.org/mozilla-central/rev/670d867ff3ba

Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.