Closed Bug 87358 Opened 23 years ago Closed 23 years ago

Pop-up window is blank from http://home.netscape.com

Categories

(SeaMonkey :: General, defect)

HP
HP-UX
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED WORKSFORME

People

(Reporter: jimmyu, Assigned: shannond)

References

()

Details

Daily HP trunk build 2001062209 Reproducible: always Steps to reproduce: 1) launch mozilla 2) if no pop-up window, clear your cookies file 3) Edit|Preferences|Privacy and Security|Cookies, click "View Stored Cookies" and "Remove All Cookies" 4) click "Reload" from the navigation bar Result: pop-up winodw is blank Expected result: some thing in pop-up window This problem doesn't happen on the Linux trunk build.
update qa to myself and add blocker
Blocks: 18687
QA Contact: doronr → jimmyu
I see this bug in build 2001062209 and my optimized build, but not my debug build that was pulled at the same time. So, this could either be an optimized/debug problem or a difference in .mozconfig options. My opt build was built with svg, mathml, irc, and crypto where my debug wasn't. Testing now ...
Looks like this may have been caused by valeski's checkin for bug 84162 - checked in 6/5 around 14:37. If I back out his checkin ( and every other revision made to these files made afterward ) I can get the pop-up image to show up again. These are the files: mozilla/modules/libimg/src/if.cpp backed out to revision 3.73 mozilla/extensions/cookie/nsModuleFactory.cpp backed out to 1.2 mozilla/extensions/cookie/nsImgManager.h backed out to 1.1 mozilla/extensions/cookie/nsImgManager.cpp backed out to 1.1 mozilla/extensions/cookie/nsIImgManager.idl backed out to 1.1 Also worth mentioning was that I was able to reproduce this bug on my debug linux build off the 0.9.2 branch this morning, however I have been unable to find a linux daily build that will show this bug.
The problem is in mozilla/modules/libimg/src/if.cpp around line 1821: PRBool permission; // commenting this out per pavlov's suggestion. he says this file is // going away soon. CheckForPermission() no longer exists. // nsIContentPolicy is used to block images now. //rv = imgmanager->CheckForPermission(host, firstHost, &permission); Recycle(host); Recycle(firstHost); if (NS_FAILED(rv)) { return PR_TRUE; } return permission; "rv = imgmanager->CheckForPermission(host, firstHost, &permission)" was commented out which left no set value for "PRBool permission". Setting "permission" to default value PR_TRUE would fix the problem with optimized HPUX builds and debug Linux builds since these builds will set "permission" to zero if no other value is supplied. However, don't know if this is the correct solution since it looks like "rv" is also used later in this section of code without a new calculated value. cc'ing pavlov and valeski
This has been fixed with pavlov's checkin for bug 78690 - Remove the old imagelib. Resolving worksforme. Build 2001081221
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
Verified with HPUX commercial trunk build 2001081221
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.