Closed Bug 874024 Opened 12 years ago Closed 12 years ago

[Web Audio API] can't create a JavaScriptNode with no Inputs

Categories

(Core :: Web Audio, defect)

24 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: emeric, Assigned: ehsan.akhgari)

References

()

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_3) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.65 Safari/537.31 Steps to reproduce: I want to use a JavaScript node as sound generator in my WebAudioAPI-enabled application. It should have two outputs for stereo, but it does not need to have any inputs (it just generates signal). Actual results: When creating my node like this : context.createJavaScriptNode(2048,0,2); // error I get the following error : IndexSizeError: Index or size is negative or greater than the allowed amount If I add at least one (unused) input, the error vanishes. context.createJavaScriptNode(2048,1,2); // fine Expected results: The Web Audio specs state that "It is invalid for both numberOfInputChannels and numberOfOutputChannels to be zero", so the output-only version of the code should work, as it does in other browsers.
Attached file jsFiddle link (obsolete) (deleted) —
Created a small fiddle with the two lines of code required to generate the error...
Component: Untriaged → Video/Audio
Product: Firefox → Core
Attachment #751653 - Attachment is obsolete: true
Blocks: webaudio
The spec has actually be re-worded to say "It is invalid for either numberOfInputChannels or numberOfOutputChannels to be zero." The reason behind this is that we still need to provide an inputBuffer on the event object, which is going to have a number of silent channels, and we can't create an AudioBuffer with 0 channels. Therefore, Gecko's behavior matches the spec, and if WebKit/Blink accept this code, that is a bug in their implementation. To get your code working, I suggest you just pass in 1 and ignore the inputBuffer attribute on the events that you will receive.
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
OK if the specs say so, but I can't find that re-wording in the current published spec. Could you please provide me with a link to that new version, so I can refer to the correct document ? The workaround you mention is the one I have been using, but I thought it was a bit tricky because there was no mention of that limitation in the available references. Thanks for the informations.
Not sure what version of the spec you're looking at, but you need to look at <https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html> I think. Also, I'm talking to Chris Rogers about this right now, and we may end up reverting that change, in which case I'll reopen this bug and update Gecko to match that, but let's see how that goes. The workaround I suggested would still make sense though.
OK, in fact I was looking at the specs for the ScriptProcessorNode where it still states that "It is invalid for both numberOfInputChannels and numberOfOutputChannels to be zero", while the spec for the createScriptProcessor() method says that "it is invalid for either numberOfInputChannels or numberOfOutputChannels to be zero". IMHO there is some contradiction in there. And I find the non-zero limitation counter-intuitive, because in the "hardware world", I would not understand why an instrument has to have an input to be able to output something. Maybe the implementation could manage that limitation behind the scene, hiding it from the user. ******** createScriptProcessor() https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#methodsandparams-AudioContext ScriptProcessorNode http://www.w3.org/TR/webaudio/#ScriptProcessorNode
(In reply to comment #7) > OK, in fact I was looking at the specs for the ScriptProcessorNode where it > still states that "It is invalid for both numberOfInputChannels and > numberOfOutputChannels to be zero", while the spec for the > createScriptProcessor() method says that "it is invalid for either > numberOfInputChannels or numberOfOutputChannels to be zero". Right, like I said this was a recent change in the spec which we might revert. I will update this bug when we reach a decision there. > createScriptProcessor() > https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#methodsandparams-AudioContext > > ScriptProcessorNode > http://www.w3.org/TR/webaudio/#ScriptProcessorNode FWIW you should probably look at the first version of the spec. It is changing a bit these days, but it's the latest version.
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: INVALID → ---
Assignee: nobody → ehsan
Attached patch Patch (v1) (deleted) — Splinter Review
Attachment #752957 - Flags: review?(roc)
Comment on attachment 752957 [details] [diff] [review] Patch (v1) Review of attachment 752957 [details] [diff] [review]: ----------------------------------------------------------------- oops, I should have caught this.
Attachment #752957 - Flags: review?(roc) → review+
Arguably we should just remove this limit altogether. Sure, an no-input no-output ScriptProcessorNode is not useful, but it's not harmful either so it's simpler to allow it.
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #12) > Arguably we should just remove this limit altogether. Sure, an no-input > no-output ScriptProcessorNode is not useful, but it's not harmful either so > it's simpler to allow it. That's fine by me. Can you please bring it up on the list?
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: