Closed
Bug 874046
Opened 11 years ago
Closed 11 years ago
Three-state UI for DNT strings should not end with a period
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 24
People
(Reporter: jaws, Assigned: rsx11m.pub)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
The strings at http://hg.mozilla.org/mozilla-central/annotate/ca7f8131a8d4/browser/locales/en-US/chrome/browser/preferences/privacy.dtd#l7 all end with a period, but I don't see any other strings related to a checkbox or radio button within the Preferences that ends with a period.
For internal consistency we should remove these periods.
Straight-forward to fix. Since some localizations have added the periods already but others didn't, I'm changing the entity names to alert them that they may need to make a modification in those strings.
I don't know what the "in-content" branch is about, but made corresponding changes there as well.
|
||
Updated•11 years ago
|
Attachment #751797 -
Flags: review?(dolske) → review+
Thanks for the quick review, push for mozilla-inbound please.
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
(In reply to rsx11m from comment #1)
> I don't know what the "in-content" branch is about, but made corresponding
> changes there as well.
I see, figured it out - setting browser.preferences.inContent shows that part.
You need to log in
before you can comment on or make changes to this bug.
Description
•