Closed Bug 874368 Opened 11 years ago Closed 10 years ago

[system] closing/removing/dismissing notifications by swiping right to left only works if starting very left

Categories

(Firefox OS Graveyard :: Gaia::System, defect, P2)

All
Gonk (Firefox OS)
defect

Tracking

(feature-b2g:2.2+, ux-b2g:2.2)

VERIFIED FIXED
2.2 S5 (6feb)
feature-b2g 2.2+
ux-b2g 2.2

People

(Reporter: aryx, Assigned: etienne)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Boot2Gecko 1.1.0.0-prerelease 20130520230207 on Unagi Removing notifications by swiping right to left only works if the swipe starts on the very left. Steps to reproduce: 1. Open the notifications menu. 2. Press Power and Home for a screenshot and its notification. 3. Start dragging to the left, starting from the position where the timestamp is ("now"). Actual result: Notification not dismissed. 4. Start dragging to the left, starting from the center. Actual result: Notification not dismissed. 5. Start dragging to the left, starting left from the text. Actual result: Notification gets dismissed. Left to right swiping works as expected.
This has potential implications for our RTL support.
Blocks: gaia-rtl
Jacqueline, I'm going through RTL bugs in conjunction with Arabic and patterns we updated during the Toronto work week. Can I resolve this as invalid based on new Notifications design since the bug was created, or no?
Flags: needinfo?(jsavory)
Passing to Rob as he has been working on notifications.
Flags: needinfo?(jsavory) → needinfo?(rmacdonald)
This to me is a valid bug. Notifications should be able to be dismissed regardless of the swipe direction.
blocking-b2g: --- → 2.0?
Flags: needinfo?(rmacdonald)
This is something we should fix, but I don't think we would hold a release on this for 2.0, since this is a long-standing bug.
blocking-b2g: 2.0? → backlog
Product - When are we planning to support RTL locales (i.e. what release)?
Flags: needinfo?(ffos-product)
Since I'm doing L10N PM, we are aiming for 2.1 but that will be late. We'd at least like to get some basic RTL support in and done for partners to cherry pick, but it was not high priority as we didn't even know until post-2.0 that Arabic was coming. Let me know if you'd like to schedule some time to talk through the roadmap.
Flags: needinfo?(ffos-product)
ux-b2g: --- → 2.1
Assigning to Pavel. Pavel, let me know if you can take this and if not I'll reassign. Thanks!
Assignee: nobody → pivanov
Hey Stephany, sorry for the delay. I think this is complicated to me. Maybe is a good idea to assign this to someone else.
Blocks: system-rtl
No longer blocks: gaia-rtl
ux-b2g: 2.1 → 2.2
Reproduces on Flame 2.1 - 2014-09-08.
Blocks: notifications-rtl
No longer blocks: system-rtl
RTL triage: P2 -- will make a best effort to get this into the 2.2 release.
Priority: -- → P2
RTL update: marking required bugs as feature-b2g:2.2+ (and removing blocking flags)
blocking-b2g: backlog → ---
feature-b2g: --- → 2.2+
I think the logic is good but the performance are so bad that it looks like it's not working. Patch incoming :)
Assignee: pivanov → etienne
Comment on attachment 8557862 [details] [PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master Hey Chris, what do you think? (Trying to keep this patch small since it's 2.2+.) Won't be easy to test so I'm requesting feedback before tackling the unit tests.
Attachment #8557862 - Flags: feedback?(chrislord.net)
Comment on attachment 8557862 [details] [PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master Looks good - bonus points if you used your inertia calculation to alter the trasition duration :)
Attachment #8557862 - Flags: feedback?(chrislord.net) → feedback+
Comment on attachment 8557862 [details] [PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master The notifications tests weren't in a very good shape :/ The unit ones weren't even running on my machine at first... but did my best!
Attachment #8557862 - Flags: review?(chrislord.net)
Comment on attachment 8557862 [details] [PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master Looks good, but I think I have enough comments that I'd like to see another run before granting r+.
Attachment #8557862 - Flags: review?(chrislord.net)
Whiteboard: [systemsfe]
Comment on attachment 8557862 [details] [PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master updated!
Attachment #8557862 - Flags: review?(chrislord.net)
Comment on attachment 8557862 [details] [PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master Couple of nits, looks good :)
Attachment #8557862 - Flags: review?(chrislord.net) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
This issue is verified fixed on Flame 3.0 and Flame 2.2 If the user swipes a notification left or right starting from anywhere on the notification, it will be dismissed as expected. Environmental Variables: Device: Flame 3.0 (319mb)(Kitkat)(Full Flash) Build ID: 20150205010209 Gaia: 2b83a6d5d1185a438b5bbd287497ac2743b501db Gecko: 34a66aaaca81 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Environmental Variables: Device: Flame 2.2 (319mb)(Kitkat)(Full Flash) Build ID: 20150205002503 Gaia: c2047a46e29696238e9b4c9caaba47736421449a Gecko: adfba0a07e9b Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0a2 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?][rtl-impact]
Flags: needinfo?(pbylenga)
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(pbylenga)
Target Milestone: --- → 2.2 S5 (6feb)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: