PLease, apply "+" add contact button hit state in blue. Attaching the button sprite with the two states-

Comment on attachment 752940 [details] [diff] [review] Implement hit state for "Add contact" button Review of attachment 752940 [details] [diff] [review]: ----------------------------------------------------------------- I can see the keyboard is coming up when tapping on the "+". Probably we need a preventDefault and/or stopPropagation in the "+" handler. Either you do it here or you file another bug for that. BTW I really feel this bug is useless: on the real device, the finger hides the "+" button anyway, we can't see the active state... r=me with removing ".icon" if it's not necessary, and filing a new bug for the preventDefault/stopPropagation. If you want to fix this here, please ask me review again. ::: apps/sms/style/sms.css @@ +261,5 @@ > .new #messages-contact-pick-button { > display: block; > } > > #messages-contact-pick-button .icon.icon-user { do we need ".icon" here ? @@ +269,5 @@ > + > + background-image: url(images/add_contact.png); > +} > + > +#messages-contact-pick-button .icon.icon-user:active { do we need ".icon" here ?

This version also simplifies the CSS selectors used because, as Julien suggested, the current selectors are needlessly specific. Carrying forward the "r+"

Landed at 12a0576f4fd4615d21e4a284723733791c070c71 Created Bug 875282 to track the issue identified in Comment 2 Thanks for the review, Julien

Uplifted 12a0576f4fd4615d21e4a284723733791c070c71 to: v1-train: 774a2fc6962ecb0eaa1d2f455129dc1f2e355137

The "+" button turns to blue on hit state to add contact in sms app. Verified as fixed on environmental variables Leo Build ID: 20130807071207 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/11bb1b0eefff Gaia: 60ca81600a080dae33058b0692ecaa213556c926 Platform Version: 18.1