Closed
Bug 874543
Opened 11 years ago
Closed 11 years ago
Running config.status from rules.mk should restart current Makefile
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
I found another area of improvement to moz.build/config.status integration with Makefile/rules.mk. If we run config.status, execution of the current Makefile should restart (because Makefile or backend.mk may have changed).
We should just need to add a new dependency or two and touch a file after config.status and we should be set. No clobber should be needed, just an update to rules.mk.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gps
Assignee | ||
Comment 2•11 years ago
|
||
I think this should do it. Tested on OS X and it seems to do the right
thing.
Attachment #752368 -
Flags: review?(mh+mozilla)
Assignee | ||
Updated•11 years ago
|
Attachment #752365 -
Attachment is obsolete: true
Comment 3•11 years ago
|
||
Comment on attachment 752368 [details] [diff] [review]
Restart Makefile execution if backend is regenerated
Review of attachment 752368 [details] [diff] [review]:
-----------------------------------------------------------------
That would work, but that also means that if, to take an extreme example, modify dom/bindings/test/moz.build, and make -C objdir/dom/bindings, you'll rebuild *everything* in dom/bindings when you'd really only want dom/bindings/test to be forced-rebuilt.
::: config/rules.mk
@@ +635,5 @@
> # other rules for the default target or else it may not run in time.
> ifndef MOZBUILD_BACKEND_CHECKED
>
> +Makefile: $(DEPTH)/backend.RecursiveMakeBackend.built
> + @$(TOUCH) Makefile
$@
Attachment #752368 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla24
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•