https://tbpl.mozilla.org/php/getParsedLog.php?id=23222242&tree=Mozilla-Inbound WINNT 6.2 mozilla-inbound opt test mochitest-browser-chrome on 2013-05-21 12:12:49 PDT for push a25a93b276a5 slave: t-w864-ix-073 12:34:29 INFO - TEST-START | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js 12:34:30 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js | Web Console opened 12:34:30 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js | tab closed 12:34:30 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js | Console message: tabview assert: should already be linked 12:34:30 INFO - TabItems_update@chrome://browser/content/tabview.js:5650 12:34:30 INFO - TabItems_onMozAfterPaint@chrome://browser/content/tabview.js:5640 12:34:30 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js | toolbox destroyed 12:34:30 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js | test the Browser Console 12:34:30 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js | Console message: tabview assert: should already be linked 12:34:30 INFO - TabItems_update@chrome://browser/content/tabview.js:5650 12:34:30 INFO - TabItems_onMozAfterPaint@chrome://browser/content/tabview.js:5640 12:34:30 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js | Browser Console opened 12:34:31 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js | the Browser Console closed 12:34:31 INFO - INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js | finished in 1344ms 12:34:31 INFO - TEST-INFO | checking window state 12:34:31 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js | uncaught exception - TypeError: preview is undefined at resource://app/modules/WindowsPreviewPerTab.jsm:371 12:34:31 INFO - Stack trace: 12:34:31 INFO - JS frame :: chrome://mochikit/content/tests/SimpleTest/SimpleTest.js :: simpletestOnerror :: line 1125 12:34:31 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 12:34:31 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_bug_871156_ctrlw_close_tab.js | Console message: tabview assert: should already be linked 12:34:31 INFO - TabItems_update@chrome://browser/content/tabview.js:5650 12:34:31 INFO - TabItems_onMozAfterPaint@chrome://browser/content/tabview.js:5640

The test seems fine - it passes in all cases and what I do is pretty much in line with other tests. It is rather odd that it started failing. If you look at the logs you will see that the exception happens in WindowsPreviewPerTab.jsm after the test finishes execution. The |preview| variable can be undefined only if the MozAfterPaint event is fired too early (before previewFromTab() can return anything) or too late (after the preview is removed from the array of known previews, during tab/window close). It seems to me that defining |this.preview| as a lazy getter was some kind of a workaround. The tab |preview| was only available after the controller is constructed. I changed the code to create the tab preview during controller construction. Since this is new code for me, please review and let me know if I got it right. It's quite possible I am missing something. Thank you! Do note I'm using Linux and I was not able to test the patch on Windows 7. Try push: https://tbpl.mozilla.org/?tree=Try&rev=4841624c11fenn

Win8 opt is green on the Try push. Very encouraging.

So regression range, should it prove useful: https://hg.mozilla.org/mozilla-central/pushloghtml?startID=24710&endID=24711

Completely green on Try. Can we get this top-orange fix landed please?

Thanks, Gavin! https://hg.mozilla.org/integration/mozilla-inbound/rev/cf2106c1f0c7

https://tbpl.mozilla.org/php/getParsedLog.php?id=23290599&tree=Mozilla-Inbound 15:15:34 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_cached_messages.js | uncaught exception - TypeError: preview is undefined at resource://app/modules/WindowsPreviewPerTab.jsm:371

Thank you Gavin and Ryan!