Closed Bug 875151 Opened 12 years ago Closed 12 years ago

Shutdown/startup race

Categories

(Firefox Health Report Graveyard :: Client: Android, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox23 fixed)

RESOLVED FIXED
Firefox 24
Tracking Status
firefox23 --- fixed

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

philor spotted this once: https://tbpl.mozilla.org/php/getParsedLog.php?id=23281618&tree=Mozilla-Inbound PROCESS-CRASH | java-exception | java.lang.NullPointerExceptionat org.mozilla.gecko.health.BrowserHealthRecorder$1$1.run(BrowserHealthRecorder.java:340) which occurs when initialization finds a null storage. That implies that init (which recently switched to a background thread run) and shutdown (which nulls-out storage) are racing.
Attached patch Proposed patch. v1 (deleted) — Splinter Review
Attachment #753040 - Flags: review?(nalexander)
Blocks: 858742
Target Milestone: --- → Firefox 24
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 753040 [details] [diff] [review] Proposed patch. v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 858742. User impact if declined: No FHR in 23. Testing completed (on m-c, etc.): Baking on m-c for some time. QA overview written up; waiting for QA to execute. Manual testing and automated unit tests. Risk to taking this patch (and alternatives if risky): Slim (improves safety). String or IDL/UUID changes made by this patch: None.
Attachment #753040 - Flags: approval-mozilla-aurora?
Comment on attachment 753040 [details] [diff] [review] Proposed patch. v1 Approving for uplift as part of the body of work for FHR's first revision on Android.
Attachment #753040 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: