Closed
Bug 875396
Opened 12 years ago
Closed 12 years ago
[MMS] Clicking an image in a failed message should open the image, not offer resend
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:leo+, b2g18 fixed)
People
(Reporter: gnarf, Assigned: gnarf)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
julienw
:
review+
|
Details | Diff | Splinter Review |
If you click on the image in a message that has failed to send, it will still open the MozActivity - the resending should be the only thing happening there.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → gnarf37
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #753370 -
Flags: review?(felash)
Assignee | ||
Comment 2•12 years ago
|
||
This patch implements it such that we can't click on the image to open, just resend the message...
Not sure which action should win here, open the image, or resend the message. CC Ayman
Flags: needinfo?(aymanmaat)
Assignee | ||
Updated•12 years ago
|
blocking-b2g: --- → leo?
Updated•12 years ago
|
blocking-b2g: leo? → leo+
Whiteboard: [NO_UPLIFT]
Comment 3•12 years ago
|
||
(In reply to Corey Frang [:gnarf] [:gnarf37] from comment #2)
> This patch implements it such that we can't click on the image to open, just
> resend the message...
>
> Not sure which action should win here, open the image, or resend the
> message. CC Ayman
Hey corey
Ideally we would have two actions associated to the message bubble each initiated depending on where the user clicks:
1) if the user select the error icon they should get an overlay detailing that the message failed to send and offering the option to resend. this is covered in page 35 and 37 of wireframe pack V8
2) if the user selects the image they open in a failed message they open the image.
is this not possible?
blocking-b2g: leo+ → leo?
Flags: needinfo?(aymanmaat)
Whiteboard: [NO_UPLIFT]
Assignee | ||
Comment 4•12 years ago
|
||
So, I guessed wrong, coming back with a new patch here soon - thanks for the clarification ayman
Assignee | ||
Updated•12 years ago
|
Summary: [MMS] Clicking to resend an image message shouldn't open the image → [MMS] Clicking to an image in a failed message should open the image, not offer resend
Updated•12 years ago
|
blocking-b2g: leo? → leo+
Whiteboard: [NO_UPLIFT]
Assignee | ||
Updated•12 years ago
|
Attachment #753370 -
Attachment is obsolete: true
Attachment #753370 -
Flags: review?(felash)
Assignee | ||
Updated•12 years ago
|
Summary: [MMS] Clicking to an image in a failed message should open the image, not offer resend → [MMS] Clicking an image in a failed message should open the image, not offer resend
Assignee | ||
Comment 5•12 years ago
|
||
Okay - this now allows you to view the attachment, but if the attachment is found, it doesn't offer the resend menu.
Attachment #753417 -
Flags: review?(felash)
Updated•12 years ago
|
Attachment #753417 -
Attachment is patch: true
Comment 6•12 years ago
|
||
Comment on attachment 753417 [details] [diff] [review]
patch v2
Review of attachment 753417 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with the nits
::: apps/sms/js/thread_ui.js
@@ +23,5 @@
> console.error('error with open activity', this.error.name);
> // TODO: Add an alert here with a string saying something like
> // "There is no application available to open this file type"
> };
> + return true;
nit: |return false| for the other return
::: apps/sms/test/unit/thread_ui_test.js
@@ +1172,2 @@
> messageContainer.appendChild(output);
> + sinon.stub(ThreadUI, 'handleMessageClick');
nit: if you use this.sinon instead of sinon, the restore is done automatically by the test agent. (this.sinon is a sandbox)
(but test that the tests pass if you change this :) )
@@ +1188,5 @@
> assert.equal(call.data.blob, testImageBlob);
> });
> + test('Does not call handleMessageClick', function() {
> + assert.isFalse(ThreadUI.handleMessageClick.called);
> + });
nit: please add some spaces to this part, between tests and setup and teardown
Attachment #753417 -
Flags: review?(felash) → review+
Assignee | ||
Comment 7•12 years ago
|
||
master: 1ea9f4ae7f3fa7090d7985f6050eebb4d26b0d02
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Whiteboard: [NO_UPLIFT]
Updated•12 years ago
|
Flags: in-moztrap-
You need to log in
before you can comment on or make changes to this bug.
Description
•