Closed
Bug 875401
Opened 11 years ago
Closed 11 years ago
Switch HealthReportGenerator to use org.json.JSONObject
Categories
(Firefox Health Report Graveyard :: Client: Android, defect)
Tracking
(firefox23 fixed)
RESOLVED
FIXED
Firefox 24
Tracking | Status | |
---|---|---|
firefox23 | --- | fixed |
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
(deleted),
patch
|
rnewman
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Currently it uses org.json.simple, like Sync. The generator, though, will end up handling add-on records that are produced by Fennec; that code uses org.json to match the rest of Fennec.
Let's switch this bit of code to match Fennec.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•11 years ago
|
||
Target Milestone: --- → Firefox 24
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•11 years ago
|
||
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Earlier FHR patch.
User impact if declined:
No FHR in 23.
Testing completed (on m-c, etc.):
Baking on m-c for some time. QA overview written up; waiting for QA to execute. Manual testing and automated unit tests.
Risk to taking this patch (and alternatives if risky):
Slim.
String or IDL/UUID changes made by this patch:
None.
Attachment #760036 -
Flags: review+
Attachment #760036 -
Flags: approval-mozilla-aurora?
Comment 5•11 years ago
|
||
Comment on attachment 760036 [details] [diff] [review]
Patch for uplift.
Approving for uplift as part of the body of work for FHR's first revision on Android.
Attachment #760036 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 6•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
status-firefox23:
--- → fixed
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•