Closed
Bug 875457
Opened 12 years ago
Closed 12 years ago
[sms] when showing the attachment options, we should blur from the input to hide the keyboard
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:leo+, b2g18 verified)
People
(Reporter: julienw, Assigned: gnarf)
References
Details
Attachments
(2 files, 3 obsolete files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
julienw
:
review+
|
Details | Diff | Splinter Review |
screenshot
STR:
* start a new message
* attach an image
* tap on the input to enter some text
* tap on the image to display the attachment menu
Expected:
* we display the menu without the keyboard
Actual:
* we have the keyboard, and the display is broken
see screenshot
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → gnarf37
|
|
Assignee | |
Comment 1•12 years ago
|
||
Try as I might - I couldn't figure out how to force something to get focus in the suite so I could write a unit test for this.
Attachment #753430 -
Flags: review?(felash)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Now with a more sane approach, and tested
Attachment #753430 -
Attachment is obsolete: true
Attachment #753430 -
Flags: review?(felash)
Attachment #753444 -
Flags: review?(felash)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #753455 -
Flags: review?(felash)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #753444 -
Attachment is obsolete: true
Attachment #753444 -
Flags: review?(felash)
|
|
Assignee | |
Comment 4•12 years ago
|
||
tabindex + focus on main element + after the element is shown = no more keyboard
Attachment #753455 -
Attachment is obsolete: true
Attachment #753455 -
Flags: review?(felash)
Attachment #753462 -
Flags: review?(felash)
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
Reporter | |
Comment 5•12 years ago
|
||
Comment on attachment 753462 [details] [diff] [review]
patch v4
Review of attachment 753462 [details] [diff] [review]:
-----------------------------------------------------------------
on a side note, vivien told me we are supposed to support the HTML5 contextmenu attribute and that we could try to use it here.
r=me, thanks !
::: apps/sms/js/attachment_menu.js
@@ +39,5 @@
> this.cancelButton.textContent = _('cancel');
>
> this.el.className = '';
> +
> + // focus the menu so we can lose focus on anything with the keyboard
nit: add a comment that this is for the "longpress/contextmenu" case
Attachment #753462 -
Flags: review?(felash) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
master: 5bfb1cc32764939c296d51e52a93643c3b874b2d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [NO_UPLIFT]
|
||
Updated•12 years ago
|
blocking-b2g: leo? → leo+
|
||
Updated•12 years ago
|
Flags: in-moztrap?
|
||
Updated•12 years ago
|
Flags: in-moztrap? → in-moztrap+
|
|
||
Comment 8•12 years ago
|
||
Added SMS Suite Test Case #8571 [SMS] The keyboard is hidden when the attachments options menu is displayed
Verified fixed, the issue no longer reproduces.
Environmental Variables
Build ID: 20130806071254
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a2a9b89ef5ee
Gaia: 4c1a20570e20f64782ba170c14604395c48f7381
Platform Version: 18.1
User is able to see the menu without the keyboard.
You need to log in
before you can comment on or make changes to this bug.
Description
•