Open
Bug 876700
Opened 11 years ago
Updated 2 years ago
Use larger desktop shortcut favicons than 16x16 for websites that provide them
Categories
(Core :: Widget: Win32, defect, P4)
Tracking
()
NEW
People
(Reporter: bbondy, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: tpi:+)
We currently only use 16x16 favicons, but sometimes websites provide larger favicons, possibly all inside a single .ico file. We should take advantage of the larger favicons for desktop shortcuts when they are available.
See widget/windows/nsDataObj.cpp
nsDataObj :: GetFileContentsInternetShortcut
And widget/windows/WinUtils.cpp
AsyncFaviconDataReady::OnComplete
For relevant code.
Updated•10 years ago
|
Blocks: hidpi-favicon-ui
Hardware: x86_64 → All
Comment 1•10 years ago
|
||
I'm interested in this bug, but I'm a bit green. After looking at the functions mentioned in Comment 1, what I've gathered is that nsDaatObj::GetFileContentsInternetShortcut() only retrieves the ICO file and its path, but is not responsible for any parsing. AsyncFaviconDataReady::OnComplete(), on the other hand, actually retrieves and draws image data. I would like some confirmation of this (as well as some pointing in the right direction) before I start working on this.
Updated•10 years ago
|
Flags: needinfo?(netzen)
Reporter | ||
Comment 2•10 years ago
|
||
Yep we have a decoder for icons at:
mozilla-central/image/decoders/nsICODecoder.h and .cpp
I haven't looked at this code in a long time, and it might have changed since I last looked at it. But when I last seen it we always only picked one of the icons and had no handling to extract different icons from within that decoder.
Flags: needinfo?(netzen)
Comment 3•10 years ago
|
||
We have the #-moz-resolution media fragment to extract specific sizes from an ICO but I'm not sure where that's done. Example: #-moz-resolution=32,32
Reporter | ||
Comment 4•10 years ago
|
||
Great, here are some ideas:
http://dxr.mozilla.org/mozilla-central/search?q=moz-resolution&redirect=true
Updated•9 years ago
|
Updated•9 years ago
|
Updated•8 years ago
|
Priority: -- → P4
Whiteboard: tpi:+
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•