Some changes are missing for gonk port. ../../../gecko/widget/gonk/nsIdleServiceGonk.h:39:16: error: could not convert 'idleService' from 'nsIdleServiceGonk*' to 'already_AddRefed<nsIdleServiceGonk>' http://hg.mozilla.org/mozilla-central/rev/321ab55f16ba#l6.12

Comment on attachment 755398 [details] [diff] [review] Fix for recent ref pointers update, build fix for gonk Review of attachment 755398 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/GonkGPSGeolocationProvider.cpp @@ +48,4 @@ > nsIRILDataCallback, > nsISettingsServiceCallback) > > +nsRefPtr<GonkGPSGeolocationProvider> GonkGPSGeolocationProvider::sSingleton; Hmm I think you introduced a behavior change so that sSingleton is never NULL'd out. It looks like this code relies on the caller of GetSingleton to drop its reference to free sSingleton, but nsRefPtr would cause it to never go away. I think we'll just want to add a nsRefPtr in GetSingleton instead so the behavior isn't changed. BTW there's StaticRefPtr for declaring a refptr in a static global context.

Comment on attachment 755711 [details] [diff] [review] Fix for recent ref pointers update, build fix for gonk Review of attachment 755711 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/GonkGPSGeolocationProvider.cpp @@ +40,4 @@ > using namespace mozilla; > > static const int kDefaultPeriod = 1000; // ms > +/* static */ StaticRefPtr<GonkGPSGeolocationProvider> GonkGPSGeolocationProvider::sSingleton; I meant to not use any refptr. The previous behavior allowed us to free this object whenever no one was using it, but this holds on to it forever.

Ah ok, sorry, misread previous message

Comment on attachment 755734 [details] [diff] [review] Fix for recent ref pointers update, build fix for gonk Looks good, thanks!