Closed Bug 877235 Opened 11 years ago Closed 11 years ago

Removal of JS_GetGlobalObject from jsdContext::GetGlobalObject breaks firebug

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

So, I think gabor's suggestion to cache the global at the right point could work. But Honza says that Firebug will stop depending on this stuff very soon (possibly this cycle). At the moment, the main reason I wanted to get rid of JS_GetGlobalObject was so that we could proceed on bug 865745. I can't imagine that we care about the interaction between Firebug and the frame message manager global, so I don't think that really conflicts here. As such, if it's ok with everyone, I'm just going to use our little backdoor function to restore the old behavior here for the interim. Let's stay on track removing JSD. :-)
Attachment #755461 - Flags: review?(gkrizsanits)
Comment on attachment 755461 [details] [diff] [review] Use the default global for just a little bit longer in JSD. v1 Review of attachment 755461 [details] [diff] [review]: ----------------------------------------------------------------- Well if it's not too urgent to remove this backdoor function then sure. I'm fine with not digging into JSD too much if we don't have to.
Attachment #755461 - Flags: review?(gkrizsanits) → review+
Thank you guys for the support I appreciate that! Honza
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: