Closed
Bug 877351
Opened 11 years ago
Closed 11 years ago
Network Panel is broken on RTL UI
Categories
(DevTools :: Netmonitor, defect, P2)
DevTools
Netmonitor
Tracking
(firefox23- verified, firefox24- verified)
VERIFIED
FIXED
Firefox 24
People
(Reporter: tomer, Assigned: vporof)
References
Details
(Keywords: rtl)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
rcampbell
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
When using the new network panel in Firefox Aurora, I can see that it is completely broken, making it unusable.
Steps to reproduce:
1. Use an RTL build.
2. Open the network panel and load a page.
Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20130523 Firefox/23.0
Updated•11 years ago
|
status-firefox23:
--- → affected
status-firefox24:
--- → affected
tracking-firefox23:
--- → ?
tracking-firefox24:
--- → ?
Assignee | ||
Comment 1•11 years ago
|
||
It's look like CSS transforms are biting our butt.
OS: Linux → All
Priority: -- → P2
Hardware: x86 → All
Comment 2•11 years ago
|
||
Is there reason to believe this is a new regression in FF23? If not, we'd take a low risk fix but wouldn't track.
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Alex Keybl [:akeybl] from comment #2)
> Is there reason to believe this is a new regression in FF23? If not, we'd
> take a low risk fix but wouldn't track.
It's been like this since the beginning.
Reporter | ||
Comment 4•11 years ago
|
||
(In reply to Victor Porof [:vp] from comment #3)
> It's been like this since the beginning.
Yes, but the network panel is pretty new, and doesn't exists in the release channel yet (web console was replaced by the network console?).
A quick workaround could be to add direction:ltr to the network panel until we'd have a better solution. Doing so will make sure we won't ship with broken features.
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Tomer Cohen :tomer from comment #4)
> (In reply to Victor Porof [:vp] from comment #3)
> > It's been like this since the beginning.
>
> A quick workaround could be to add direction:ltr to the network panel until
> we'd have a better solution. Doing so will make sure we won't ship with
> broken features.
Is there a way to query the current text direction in js? Everything is caused by a "translateX" matrix applied to individual network waterfall nodes. Although elegant, as far as I know, there's nothing like a mozTranslateStart that can be used instead of transformX.
Comment 6•11 years ago
|
||
(In reply to comment #5)
> (In reply to Tomer Cohen :tomer from comment #4)
> > (In reply to Victor Porof [:vp] from comment #3)
> > > It's been like this since the beginning.
> >
> > A quick workaround could be to add direction:ltr to the network panel until
> > we'd have a better solution. Doing so will make sure we won't ship with
> > broken features.
>
> Is there a way to query the current text direction in js? Everything is caused
> by a "translateX" matrix applied to individual network waterfall nodes.
> Although elegant, as far as I know, there's nothing like a mozTranslateStart
> that can be used instead of transformX.
if |e| is a DOM element, you could do:
var isRTL = window.getComputedStyle(document.body, null).direction == "rtl";
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #6)
>
> var isRTL = window.getComputedStyle(document.body, null).direction == "rtl";
Thanks, that'll have to do.
Assignee | ||
Comment 8•11 years ago
|
||
Reporter | ||
Comment 10•11 years ago
|
||
(In reply to lsblakk@mozilla.com [:lsblakk] from comment #9)
> not tracking based on comment 3 - please nominate for uplift if low risk.
Is it possible in the meantime to workaround this issue with dir=ltr, so we won't ship this feature broken for every user with browser locale set to {ar,fa,he}?
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Tomer Cohen :tomer from comment #10)
> (In reply to lsblakk@mozilla.com [:lsblakk] from comment #9)
> > not tracking based on comment 3 - please nominate for uplift if low risk.
>
> Is it possible in the meantime to workaround this issue with dir=ltr, so we
> won't ship this feature broken for every user with browser locale set to
> {ar,fa,he}?
No need for that, I submitted a patch with a straightforward fix (comment #8). Just waiting for review and then I'll ask for aurora approval.
Comment 12•11 years ago
|
||
Comment on attachment 757144 [details] [diff] [review]
v1
Review of attachment 757144 [details] [diff] [review]:
-----------------------------------------------------------------
OK! Thanks.
Attachment #757144 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 13•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 14•11 years ago
|
||
Comment on attachment 757144 [details] [diff] [review]
v1
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Network Monitor is hideous on RTL builds
User impact if declined: Diverse groups of people would be greatly saddened to experience such ugliness and utter lack of usability
Testing completed (on m-c, etc.): Locally, fx-team
Risk to taking this patch (and alternatives if risky): None, really straightforward fix, small patch
String or IDL/UUID changes made by this patch: None
Attachment #757144 -
Flags: approval-mozilla-aurora?
Comment 15•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Updated•11 years ago
|
Attachment #757144 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•11 years ago
|
Assignee | ||
Comment 16•11 years ago
|
||
Aurora try looks good: https://tbpl.mozilla.org/?tree=Try&rev=45406b7a9b03
Assignee | ||
Comment 17•11 years ago
|
||
Comment 18•11 years ago
|
||
This appears to be fixed on the build from https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/23.0b4-candidates/build1/mac/en-US/
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•11 years ago
|
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•