Closed
Bug 877523
Opened 11 years ago
Closed 11 years ago
WebAudio global-buffer-overflow crash [@mozilla::dom::DelayNodeEngine::ProduceAudioBlock]
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
| Tracking | Status | |
|---|---|---|
| firefox22 | --- | disabled |
| firefox23 | - | disabled |
| firefox24 | + | fixed |
| firefox-esr17 | --- | unaffected |
| b2g18 | --- | unaffected |
People
(Reporter: posidron, Assigned: ehsan.akhgari)
References
Details
(4 keywords, Whiteboard: [adv-main24-])
Attachments
(4 files, 1 obsolete file)
content/media/webaudio/DelayNode.cpp:215
// Write the input sample to the correct location in our buffer
if (input) {
* buffer[writeIndex] = input[i] * aInput.mVolume;
}
Tested with http://hg.mozilla.org/integration/mozilla-inbound/rev/c9e6ca6528b8
|
Reporter | |
Comment 1•11 years ago
|
||
|
|
Reporter | |
Comment 2•11 years ago
|
||
|
|
Reporter | |
Comment 3•11 years ago
|
||
|
Assignee | |
Comment 4•11 years ago
|
||
OK, this is really embarrassing. We ended up calculating 0 for all maxDelay values less than 1, so the internal buffer's size would end up being 0.
|
|
Assignee | |
Comment 5•11 years ago
|
||
Attachment #755980 -
Attachment is obsolete: true
Attachment #755980 -
Flags: review?(roc)
Attachment #756073 -
Flags: review?(roc)
|
||
Updated•11 years ago
|
status-b2g18:
--- → unaffected
status-firefox22:
--- → disabled
status-firefox23:
--- → affected
status-firefox24:
--- → affected
status-firefox-esr17:
--- → unaffected
tracking-firefox23:
--- → ?
tracking-firefox24:
--- → ?
Attachment #756073 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
|
||
Updated•11 years ago
|
Flags: in-testsuite+
|
||
Updated•11 years ago
|
|
|
Assignee | |
Comment 8•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
|
||
Comment 9•11 years ago
|
||
No longer tracking for FF23
|
||
Updated•11 years ago
|
Whiteboard: [adv-main24-]
|
||
Updated•10 years ago
|
Group: core-security
You need to log in
before you can comment on or make changes to this bug.
Description
•