Closed
Bug 877726
Opened 12 years ago
Closed 12 years ago
Convert FrameMetrics.mScrollOffset to be a gfx::Point<CSSPixel>
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ajones
:
review+
|
Details | Diff | Splinter Review |
Follow-up from bug 865735 - we is an incremental propagation of pixel-units information to some uses of gfx::Point, gfx::Size, and gfx::Rect.
Attachment #756040 -
Flags: review?(ajones)
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → bugmail.mozilla
|
||
Comment 1•12 years ago
|
||
Comment on attachment 756040 [details] [diff] [review]
Patch
Review of attachment 756040 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/base/nsDisplayList.cpp
@@ +617,5 @@
> const nsDisplayItem::ContainerParameters& aContainerParameters,
> bool aMayHaveTouchListeners) {
> nsPresContext* presContext = aForFrame->PresContext();
> int32_t auPerDevPixel = presContext->AppUnitsPerDevPixel();
> + int32_t auPerCSSPixel = nsPresContext::AppUnitsPerCSSPixel();
auPerCSSPixel is only used once so could be inlined
Attachment #756040 -
Flags: review?(ajones) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Landed with auPerCSSPixel inlined as requested:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bb24851fd4a
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•