In Gaia 55e7cf33b951406f8d6124e237177f7b43898a81, Dialer App will save the wrong contact name when user have these two contacts: 1. A contact has phone number without international code (e.g., 0933080123). 2. Another contact has phone number with international code(e.g., +886933080123). STP: 1. Save these two contacts: a) Evan, 0933080123 b) iEvan, +886933080123 2. Call "Evan" from contacts page in Dialer App, then hang up. 3. Call "iEvan" from contacts page in Dialer App, then hang up. Expected: It shows the below in the Call log page. iEvan, +886933080123 Evan, 0933080123 Current: It shows the below in the Call log page. iEvan, +886933080123 iEvan, 0933080123 And we could see the bug in the "issue screenshot" attachment.

Hi all, For the issue, I found out that when we call "Evan" with 0933080123, the oncall.html page shows "iEvan" with +886933080123 not "Evan". I think it might be the root cause of the bug. So we could check the findByNumber function in the dialer/js/contacts.js.

It is reproduced in leo device

Hi Etienne, Please help me review the patch. Thanks. :)

Are you sure about the expected result? My understanding is that for those STR the result should be only 1 entry in the call log displaying "iEvan or 1 other". Needinfoing UX to check this.

Comment on attachment 758502 [details] Point to GitHub pull request: https://github.com/mozilla-b2g/gaia/pull/10215 Clearing the review flag while waiting for UX input.

Flagging Rob on expected result since this is leo+.

Actually Stephany to the best of my knowledge i am supposed to be looking over the call log for V1.1 Etienne In the event that two contacts in the contact list have the same phone number the expected behavior in the call log is that the first contact in the contact list when it read alphabetically A-Z will be output. We no longer output " 'name' or 1 other ". There is a related bug, I will find it for you

Oh, thanks Ayman! I thought this may have come too late in the day on a Friday for you to see it, which is part of why I flagged Rob. Feel free to take this instead and clear the flags if so. Thanks!

(In reply to ayman maat :maat from comment #7) > Actually Stephany to the best of my knowledge i am supposed to be looking > over the call log for V1.1 > > Etienne > > In the event that two contacts in the contact list have the same phone > number the expected behavior in the call log is that the first contact in > the contact list when it read alphabetically A-Z will be output. We no > longer output " 'name' or 1 other ". > > There is a related bug, I will find it for you And can you comment on the grouping behavior? Thanks!

Hi Ayman, Is the number +886933080123 is same as 0933080123 in your opinion? If so, in the STR, the expected result in Call log page is Evan, +886933080123 Evan, 0933080123 Is it right? Thanks. :)

(In reply to Evan Tseng [:evanxd] from comment #10) > Hi Ayman, > > Is the number +886933080123 is same as 0933080123 in your opinion? > > If so, in the STR, the expected result in Call log page is > Evan, +886933080123 > Evan, 0933080123 > > Is it right? > Thanks. :) Sadly its not my opinion. Grouping mechanism is all supposed to depend on what SIM you have in the phone because it was specified that we would define MCC from the SIM present in the phone. So if you have three contacts with the following numbers Contact 1, +886933080123 Contact 2, 0933080123 Contact 3, +496933080123 ...and you have a Taiwanese SIM in your phone, contact 1 and 2 should be grouped, but contact 3 will stand alone. However it would seem that we have a bug (probably located in phone number lib) as we are not grouping based on the MCC of SIM. We are raise some bugs regarding this.

Hi Ayman, So if we have these two contacts: a) Evan, 0933080123 b) iEvan, +886933080123. When user makes phone call with 0933080123, the Dialer App will show Evan. And when user makes phone call with +886933080123, the Dialer App will show iEvan. Is that right?

(In reply to Evan Tseng [:evanxd] from comment #12) > Hi Ayman, > > So if we have these two contacts: a) Evan, 0933080123 b) iEvan, > +886933080123. > > When user makes phone call with 0933080123, the Dialer App will show Evan. > And when user makes phone call with +886933080123, the Dialer App will show > iEvan. > > Is that right? Hi Evan No to the best of my knowledge that is not correct. Like i say it dependent on the SIM card in the phone and the way we read the contact list. If you have a Taiwanese SIM in your phone and the following contacts in your phones contact list Evan, 0933080123 iEvan, +886933080123. 1) and dial 0933080123 the dialer app will show Evan 2)and dial +886933080123 the dialer app will show Evan This is because 0933080123 and +886933080123 are the same number in Taiwan and we show the first instance of the contact with that phone number that is in the contact list as we read alphabetically A to Z.

We expect any solution here to be regression prone, so we'd rather not take this at all. The requirements to repro are so edge casey, and the user impact isn't awful. Please reconsider.

Partner will check STR from description and reconsider if this conflicts the target market requirement. They'll set flags accordingly after. Note there are a few bugs tracking such number matching scenarios, this one seems to me the least serious.

Hi Wayne, So we should wait for partner's responses to decide that we will fix this bug or just close the bug with WONTFIX, right? Thanks. :)

Hi Wayne, Or for the master branch, we could just fix this bug with following Ayman's comments in Comment 13.

I check this issue, but still remain some bug. If I don't select any call log, deselect all button is enabled I think select all button should be enabled

Comment on attachment 765274 [details] Deslect all button is enabled Sorry. I mistake. I upload wrong image

Hi Leo, I could not reproduce the issue in Comment 18. Could you give us the STR to reproduce that? And we could file a new bug for the bug. Thanks. :)

Sorry. I mistake to upload. Comment 18 should be uploaded to Bug 883787.

(In reply to Leo from comment #21) > Sorry. I mistake to upload. Comment 18 should be uploaded to Bug 883787. I really sorry. Bug 883787 -> Bug 883760

Hi Leo, It is fine. I got it. Thanks. :)

Firefox OS is not being worked on