Closed
Bug 878000
Opened 12 years ago
Closed 12 years ago
ProxyAutoconfig should set a stack quotum when creating a JS runtime
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: ejpbruel, Assigned: ejpbruel)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
ProxyAutoConfig creates a new JS runtime. Whenever we do this, we also need to set a stack quotum. Not doing this could cause JS_CHECK_RECURSION to report false positives.
This is blocking us from landing bug 637572.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #756453 -
Flags: review?(khuey)
Comment on attachment 756453 [details] [diff] [review]
Single line fix
Review of attachment 756453 [details] [diff] [review]:
-----------------------------------------------------------------
I may be overstepping my bounds a little bit by r+ing this, but I'm going to do it anyways.
::: netwerk/base/src/ProxyAutoConfig.cpp
@@ +528,5 @@
> + /*
> + * Not setting this will cause JS_CHECK_RECURSION to report false
> + * positives
> + */
> + JS_SetNativeStackQuota(mRuntime, 128 * sizeof(size_t) * 1024);
More extra whitespace at EOL.
Attachment #756453 -
Flags: review?(khuey) → review+
|
||
Comment 3•12 years ago
|
||
kyle's review is fine by me. (and appreciated too!)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Assignee: nobody → ejpbruel
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•