Closed Bug 878106 Opened 12 years ago Closed 11 years ago

Cut/Copy/Paste edit controls don't copy and paste non-form content text properly

Categories

(Firefox :: Toolbars and Customization, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:M8][Australis:P1])

Attachments

(1 file)

STR: 1) Select some non-form text on a page 2) Open the menu panel and click "copy" to copy it to the clipboard 3) Choose the search input in the nav-bar 4) Open the menu panel What happens? Paste is disabled. What's expected? Paste should be enabled, and clicking on it should paste the clipboard contents into the search input.
I think it's worth to mention that this works as expected (for me) on Mac OSX and Linux (Ubuntu). Should we change the platform flags?
OS: All → Windows 7
Whiteboard: [Australis:M?] → [Australis:M7]
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Removing the items from M7 that do not block landing on m-c.
Whiteboard: [Australis:M7] → [Australis:M?]
Whiteboard: [Australis:M?] → [Australis:M?][Australis:P1]
This WFM on Windows and OS X. Mike (C), can you still reproduce this? :-)
Flags: needinfo?(mconley)
Yep. http://screencast.com/t/36Fo0hoUbt What's worse, is that when I click on the button, the panel closes now (it didn't do this before), which gives me the impression that something happened...but the paste didn't happen. I guess that's a separate bug though.
Flags: needinfo?(mconley)
Realized this was just a question of calling updateEditUIVisibility in the ri ght places, like we do for menus. Whoops!
Attachment #777738 - Flags: review?(bmcbride)
Assignee: bmcbride → gijskruitbosch+bugs
Comment on attachment 777738 [details] [diff] [review] should call updateEditUIVisibility when opening panel, Review of attachment 777738 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/customizableui/content/panelUI.js @@ +78,5 @@ > this.hide(); > } else if (this.panel.state == "closed") { > this.ensureRegistered(); > this.panel.hidden = false; > + let editControlPlacement = CustomizableUI.getPlacementOfWidget('edit-controls'); Nit: Convention is double quotes.
Attachment #777738 - Flags: review?(bmcbride) → review+
Whiteboard: [Australis:M?][Australis:P1] → [Australis:M8][Australis:P1][fixed-in-ux]
Egh, I meant > Pushed with nits fixed, https://hg.mozilla.org/projects/ux/rev/c14e95e3b87f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M8][Australis:P1][fixed-in-ux] → [Australis:M8][Australis:P1]
Target Milestone: --- → Firefox 28
Tested on :--- User Agent : Mozilla/5.0 (Windows NT 6.2; rv:28.0) Gecko/20100101 Firefox/28.0 Version : Firefox 28.0a1 Platform Tested : x86_64, Win 8 Status : Found Fixed.
Marking this verified based on comment 10. Thanks for your help Ganesh.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: