Closed Bug 878126 Opened 11 years ago Closed 11 years ago

Subscribe button has no icon in the customization palette for Retina displays

Categories

(Firefox :: Toolbars and Customization, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: mikedeboer)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [Australis:M7])

Attachments

(1 file, 1 obsolete file)

STR: 1) In OSX with a Retina display, enter customization mode 2) Look at the subscribe icon It has no icon. :/ See http://cl.ly/image/3R3S3h0v0N16
Whiteboard: [Australis:M?] → [Australis:M7]
Stephen, I think we'll need an upscaled icon for this.
Assignee: nobody → shorlander
Status: NEW → ASSIGNED
There is an @2x icon in the menuPanel-icons@2x.png sprite
Assignee: shorlander → mdeboer
Blocks: 878128
Mike, this is a patch that fixes it, but in a dirty way... (old) XUL button selectors, `#feed-button` in this case, take precedence over the descendant selector inside the hidpi media query block. I can take this route, but I could also add more selectors to define the list-image that are more specific and include the XUL button ids (using `@primaryToolbarButtons@`?).
Attachment #761998 - Flags: feedback?(mconley)
Comment on attachment 761998 [details] [diff] [review] Fix HiDPI icons for XUL buttons inside the customization palette Review of attachment 761998 [details] [diff] [review]: ----------------------------------------------------------------- Hm, yeah, I don't prefer this solution. Using @primaryToolbarButtons@ in a :-moz-any sounds like a better solution. Perhaps these rules can go directly in browser.css after the .toolbarbutton-1 rules.
Attachment #761998 - Flags: feedback?(mconley)
Attachment #761998 - Attachment is obsolete: true
Attachment #762024 - Flags: review?(mconley)
Comment on attachment 762024 [details] [diff] [review] Fix HiDPI icons for XUL buttons inside the customization palette Review of attachment 762024 [details] [diff] [review]: ----------------------------------------------------------------- This looks right to me. Thanks Mike!
Attachment #762024 - Flags: review?(mconley) → review+
Whiteboard: [Australis:M7] → [Australis:M7][fixed-in-ux]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][fixed-in-ux] → [Australis:M7]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: