Closed Bug 878500 Opened 11 years ago Closed 11 years ago

[UX-Branch] Wrong icons shown for addons, developer-tools, history, preferences, private-browsing in menubar

Categories

(Firefox :: Toolbars and Customization, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: linux.user.since.2002, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:M?])

Trying the UX-Branch nightly given the changes planned for v25: http://blog.mozilla.org/addons/2013/05/27/major-compatibility-changes-coming-for-firefox-25/ The following icons are inconsistently styled: * addons * developer tools * history * preferences * private browsing and possibly others. Expected: Appearance remains consistent in *ALL* locations. Actual: Shows what appears to be an multi-icon image when placed in menubar. There's likely CSS rules that need to be applied to crop to the correct sub-image.
Interim Workaround: #toolbar-menubar :-moz-any( #add-ons-button, #developer-button, #find-button, #history-panelmenu, #open-file-button, #preferences-button, #privatebrowsing-button, #save-page-button ) { list-style-image: url(chrome://browser/skin/customizableui/menuPanel-icons.png) !important; } #toolbar-menubar #add-ons-button { -moz-image-region: rect(64px, 64px, 96px, 32px) !important; } #toolbar-menubar #developer-button { -moz-image-region: rect(128px, 96px, 160px, 64px) !important; } #toolbar-menubar #find-button { -moz-image-region: rect(128px, 64px, 160px, 32px) !important; } #toolbar-menubar #history-panelmenu { -moz-image-region: rect(64px, 32px, 96px, 0px) !important; } #toolbar-menubar #open-file-button { -moz-image-region: rect(32px, 32px, 64px, 0px) !important; } #toolbar-menubar #preferences-button { -moz-image-region: rect(160px, 64px, 192px, 32px) !important; } #toolbar-menubar #privatebrowsing-button { -moz-image-region: rect(0px, 96px, 32px, 64px) !important; } #toolbar-menubar #save-page-button { -moz-image-region: rect(32px, 64px, 64px, 32px) !important; } #toolbar-menubar :-moz-any( #add-ons-button, #developer-button, #find-button, #history-panelmenu, #open-file-button, #preferences-button, #privatebrowsing-button, #save-page-button ) > .toolbarbutton-icon { max-height: 16px !important; } NOTE: CSS selector is intentionally *NOT* #toolbar-menubar > * as during customization, the toolbar items are wrapped with additional intermediate elements. This ensures that the correct images are shown both normally and during customization. NOTE: #history-panelmenu appears to also be incorrectly displayed in the toolbar. This was not addressed by the workaround above.
Whiteboard: [Australis:M?]
Thanks for the report. Can you still reproduce this issue with the latest UX Nightly?
Version: 24 Branch → Trunk
(In reply to Matthew N. [:MattN] from comment #2) > Thanks for the report. Can you still reproduce this issue with the latest UX > Nightly? I just filed bug 892959, which has a bit more detail. Not sure if they're dupes or not.
Assuming this is fixed in current UX (or is covered by 892959). Please reopen if not.
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.