Closed Bug 878614 Opened 11 years ago Closed 11 years ago

Handle subdocument loads/unloads in the inspector

Categories

(DevTools :: Inspector, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

Attachments

(1 file)

Attached patch v1 (deleted) — Splinter Review
No description provided.
Attachment #757174 - Flags: review?(jwalker)
Comment on attachment 757174 [details] [diff] [review] v1 Review of attachment 757174 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/devtools/server/actors/inspector.js @@ +561,5 @@ > } > } > +const { Unknown } = require("sdk/platform/xpcom"); > +const { Class } = require("sdk/core/heritage") > +var ProgressListener = Class({ Could you document the point of ProgressListener? I guess something like: /** * ProgressListener makes it easier to be a notified of * the start and finish of the loading of async * requests. * See nsIWebProgressListener for details * https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIWebProgressListener */ @@ +575,5 @@ > + destroy: function() { > + this.webProgress.removeProgressListener(this); > + }, > + > + onStateChange: makeInfallible(function stateChange(progress, request, flag, status) { What does makeInfallible do?
Attachment #757174 - Flags: review?(jwalker) → review+
Assignee: nobody → dcamp
Whiteboard: [fixed-in-fx-team]
No longer blocks: remote-inspector
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: