Closed
Bug 878765
Opened 11 years ago
Closed 11 years ago
Add missing incrementation in AudioBlockPanStereoToStereo
Categories
(Core :: Web Audio, defect)
Core
Web Audio
Tracking
()
RESOLVED
INVALID
People
(Reporter: padenot, Assigned: padenot)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 757368 [details] [diff] [review]
patch
Not sure how this went unnoticed for so long. I'll be working on properly testing this node.
Attachment #757368 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 3•11 years ago
|
||
And the same one below.
Attachment #757387 -
Flags: review?(ehsan)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #757368 -
Attachment is obsolete: true
Attachment #757368 -
Flags: review?(ehsan)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 757387 [details] [diff] [review]
Add missing incrementation in AudioBlockPanStereoToStereo.
Review of attachment 757387 [details] [diff] [review]:
-----------------------------------------------------------------
Shoot!
Attachment #757387 -
Flags: review?(ehsan) → review+
|
|
||
Comment 5•11 years ago
|
||
Blink has a number of tests for the panner node. Can you please look into porting them over, or at least writing some of our own? Thanks!
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
|
Assignee | |
Comment 7•11 years ago
|
||
This got backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/a2de97d3a53f, relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/61862dc749ca.
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Updated•11 years ago
|
Component: Video/Audio → Web Audio
|
|
||
Comment 9•11 years ago
|
||
Backed out due to bug 880202.
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfcabf3d307a
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla24 → ---
|
|
||
Comment 10•11 years ago
|
||
There's no bug here!
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•