This function has been dead code for a while. It was added in bug 100215 and now we remember the certs in a different way. The other code added in bug 100215 was already removed previously.

This was used by the old support for signed scripts. Signed script support was removed some time in the last few months.

Comment on attachment 757799 [details] [diff] [review] Part 1: Remove nsNSSComponent::RememberCert Review of attachment 757799 [details] [diff] [review]: ----------------------------------------------------------------- Almost perfect (I like remove deadcode patches).However, when testing locally (after a recent rebase) showed that a header declaration was needed in a later patch. Otherwise this would have been and r+ ::: security/manager/ssl/src/nsNSSComponent.h @@ -26,5 @@ > #include "nsSmartCardMonitor.h" > #endif > #include "nsINSSErrorsService.h" > #include "nsNetUtil.h" > -#include "nsHashtable.h" A more recent patch requires this header. Do not remove.

Comment on attachment 757805 [details] [diff] [review] Part 2: Remove mScriptSecurityManager Review of attachment 757805 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.

Comment on attachment 757799 [details] [diff] [review] Part 1: Remove nsNSSComponent::RememberCert cviecco, I fixed the issue you noted and landed this: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c033a95ef26

Comment on attachment 757805 [details] [diff] [review] Part 2: Remove mScriptSecurityManager Honza, I looked over this again and it isn't worth your time to look at it. It's just trivial dead code removal and it was already reviewed by cviecco. https://hg.mozilla.org/integration/mozilla-inbound/rev/6876a29a65db

https://hg.mozilla.org/mozilla-central/rev/3c033a95ef26 https://hg.mozilla.org/mozilla-central/rev/6876a29a65db