Closed
Bug 879671
Opened 11 years ago
Closed 11 years ago
B2G RIL: Add on-off switch for Cell Broadcast functions
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
People
(Reporter: vicamo, Assigned: vicamo)
References
Details
(Whiteboard: [fixed-in-birch])
Attachments
(4 files, 1 obsolete file)
(deleted),
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
This is Gecko part work for bug 874796, user story for enable/disable Cell Broadcast.
Assignee | ||
Comment 1•11 years ago
|
||
In latest update in bug 874796 comment 8, "All channels - emergency and non-emergency channels should be switched on/off with this single option as per agreement with Operator."
We'll introduce a new boolean, default false, Settings entry "ril.cellbroadcast.disabled" to turn off Cell Broadcast completely even with non-empty CBMI/CBMID/CBMIR/MMI ("ril.cellbroadcast.searchlist") settings.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → vyang
blocking-b2g: --- → leo?
Assignee | ||
Comment 3•11 years ago
|
||
Refactor setDebugEnabled to setInitialOptions. We always need a way to pre-set some parameters to ril_work at the very beginning stage. DEBUG flag and CLIENT_ID are two examples. Another new parameter, Cell Broadcast Disabled, is going to be added in the second patch.
Attachment #759345 -
Flags: review?(allstars.chh)
Assignee | ||
Updated•11 years ago
|
Attachment #759345 -
Attachment description: m-c patch → m-c patch 1/2
Assignee | ||
Comment 4•11 years ago
|
||
Implement "ril.cellbroadcast.disabled" that works as both Settings and Preference. This parameter suggests RIL to disable CB function as possible. On failure to disable/enable CB, the preference will not be rolled back to its original value.
Attachment #759350 -
Flags: review?(allstars.chh)
Assignee | ||
Comment 5•11 years ago
|
||
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 759350 [details] [diff] [review]
m-c patch 2/2
Review of attachment 759350 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/system/gonk/RadioInterfaceLayer.js
@@ +1953,5 @@
> let setting = JSON.parse(data);
> this.handleSettingsChange(setting.key, setting.value, setting.message);
> break;
> + case kPrefenceChangedObserverTopic:
> + if (data == kCellBroadcastDisabled) {
can we use === ?
Attachment #759350 -
Flags: review?(allstars.chh) → review+
Attachment #759345 -
Flags: review?(allstars.chh) → review+
Assignee | ||
Comment 8•11 years ago
|
||
1) address review comments
2) fix unable to deactivate CB when search list is completely empty.
Attachment #759641 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Attachment #759350 -
Attachment is obsolete: true
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/2fee4d3f4941
https://hg.mozilla.org/projects/birch/rev/fb94126589a7
Whiteboard: [fixed-in-birch]
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2fee4d3f4941
https://hg.mozilla.org/mozilla-central/rev/fb94126589a7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Comment 11•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/077f6ed61541
https://hg.mozilla.org/releases/mozilla-b2g18/rev/bb6c9375f53b
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-firefox22:
--- → wontfix
status-firefox23:
--- → wontfix
status-firefox24:
--- → fixed
Comment 12•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/077f6ed61541
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/bb6c9375f53b
status-b2g-v1.1hd:
--- → fixed
Updated•11 years ago
|
Flags: in-moztrap-
Comment 13•11 years ago
|
||
Hi Vicamo, why are you toggling on the preference rather than the setting? The situation seems very similar, if not the same, as ril.radio.disabled but the solution is different. Why is that?
Flags: needinfo?(vyang)
Assignee | ||
Comment 14•11 years ago
|
||
(In reply to Michael Schwartz [:m4] from comment #13)
> Hi Vicamo, why are you toggling on the preference rather than the setting?
> The situation seems very similar, if not the same, as ril.radio.disabled but
> the solution is different. Why is that?
Because desktop Firefox may not have Settings correctly setup. We map Settings entries to preferences whenever possible so that we may implement that same function on desktop some day.
Flags: needinfo?(vyang)
You need to log in
before you can comment on or make changes to this bug.
Description
•