Martin Stránský [:stransky] (ni? me) Assignee
	Description • 11 years ago

+++ This bug was initially created as a clone of Bug #627699 +++

GTK+ 3.0 and GNOME 3 are approaching and we should get Firefox ready for them. This bug is about browser directory.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 1 • 11 years ago

Benjamin, can you please check this one? Thanks!

	Benjamin Smedberg
	Comment 2 • 11 years ago

Comment on attachment 758566 [details] [diff] [review]
patch

Not really.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 3 • 11 years ago

Better one. Mike is away so let's ask Karlt for review. Try run for this patch - https://tbpl.mozilla.org/?tree=Try&rev=85cc0612ddc5

	Karl Tomlinson (:karlt)
	Comment 4 • 11 years ago

Comment on attachment 760332 [details] [diff] [review]
v2

>-elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gtk2':
>+elif CONFIG['MOZ_ENABLE_GTK']:

I think MOZ_WIDGET_GTK is better, assuming that works.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 5 • 11 years ago

Thanks. An updated patch for check-in.

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/0cb01583448b

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/0cb01583448b

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 11 years ago

What's wrong with this picture?

diff --git a/browser/base/content/test/Makefile.in b/browser/base/content/test/Makefile.in
--- a/browser/base/content/test/Makefile.in
+++ b/browser/base/content/test/Makefile.in

 # test_contextmenu.html is disabled on Linux due to bug 513558
-ifneq (gtk2,$(MOZ_WIDGET_TOOLKIT))
+ifdef MOZ_WIDGET_GTK

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca367f2c1f8e

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 10 • 11 years ago

Yes, thanks for the fix!

	Ed Morley [:emorley]
	Comment 11 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/ca367f2c1f8e