Closed
Bug 880124
Opened 11 years ago
Closed 11 years ago
-moz-mac-fullscreen-button should be 0px wide on 10.6
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: MattN, Assigned: mstange)
References
Details
(Whiteboard: [Australis:M7])
Attachments
(1 file)
|
(deleted),
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
(Quoting Markus Stange from bug 851652 comment #63)
> (In reply to Steven Michaud from comment #62)
> > > The only slight glitch is that the size for the (non-existent)
> > > full-screen button is still defaulting to 20, where it should really
> > > be 0 in this case.
> >
> > I'm not entirely sure what you mean. Are you saying that the
> > non-existent full-screen button somehow "takes up space"?
>
> Oops, my fault. I hardcoded the size to (20, 0) in bug 868211, regardless of
> platform...
There is no native fullscreen button on 10.6 but we are taking up space for it. This impacts the fix for bug 872636.
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Comment on attachment 759008 [details] [diff] [review]
patch
Looks fine to me.
Attachment #759008 -
Flags: review?(smichaud) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Whiteboard: [Australis:M7] → [Australis:M7][fixed-in-ux]
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][fixed-in-ux] → [Australis:M7]
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•