Closed
Bug 880421
Opened 12 years ago
Closed 11 years ago
Bump migration currentUIVersions for removing text&icons mode and un-collapsing nav-bar in nsBrowserGlue.js
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Whiteboard: [Australis:M7][User Research Build+])
Attachments
(1 file)
|
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
It looks like a UI migration slipped in from m-c and nobody noticed - that'd be from bug 870112.
Our numbers are off now - currentUIVersion < 13 is now applied to two migrations - the one from bug 870112 and the one from bug 573329. This means that the one for bug 870545 needs to be bumped too.
|
||
Comment 1•12 years ago
|
||
(In reply to Mike Conley (:mconley) from comment #1)
> It looks like a UI migration slipped in from m-c and nobody noticed - that'd
> be from bug 870112.
>
> Our numbers are off now - currentUIVersion < 13 is now applied to two
> migrations - the one from bug 870112 and the one from bug 573329. This means
> that the one for bug 870545 needs to be bumped too.
Should we coalesce all the UX branch migrations into a single one?
|
Assignee | |
Comment 2•12 years ago
|
||
I don't see precedent in the other migrations for that sort of thing (and I would have expected to see it in the Firefox 4 changes) so my instincts are kinda against it.
|
|
||
Updated•12 years ago
|
Whiteboard: [Australis:M7] → [Australis:M7][User Research Build+]
|
|
Assignee | |
Comment 3•12 years ago
|
||
I'm pretty sure it's this simple.
Attachment #759777 -
Flags: review?(gijskruitbosch+bugs)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 759777 [details] [diff] [review]
Patch v1
I'm pretty sure too!
Attachment #759777 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Landed on UX as https://hg.mozilla.org/projects/ux/rev/81509da96d97
Whiteboard: [Australis:M7][User Research Build+] → [Australis:M7][User Research Build+][fixed-in-ux]
|
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][User Research Build+][fixed-in-ux] → [Australis:M7][User Research Build+]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•