Closed
Bug 881155
Opened 11 years ago
Closed 11 years ago
hdpi/xhdpi resolution assets and layout for Message app
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:hd+, b2g-v1.1hd fixed)
People
(Reporter: timdream, Assigned: steveck)
References
Details
Attachments
(1 file)
This bug represents fixes needed in Message app in order to deliver bug 881126:
-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.
As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.
The patch on top of v1-train should land on v1.1hd.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → schung
Assignee | ||
Comment 2•11 years ago
|
||
Hi Rex, this patch is only for sync the css diff between master and hd. I'll fire another patch for master (and uplift to hd) in Bug 884975.
Attachment #771899 -
Flags: review?(rexboy)
Comment 3•11 years ago
|
||
Comment on attachment 771899 [details]
Patch for hd branch only
Looks good to me. Thanks!
I excepted we land most of the @1.5x landed here but it's ok for me if you would like to land them in Bug 884975.
Attachment #771899 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Land in v1.1.0hd : 7ebb8625018024cc547e20d6c4738464edee95ea
Assignee | ||
Updated•11 years ago
|
Comment 5•11 years ago
|
||
Steve, can you confirm whether or not anything still needs to land in master here for 1.2 hdpi support?
Flags: needinfo?(schung)
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Alex Keybl [:akeybl] from comment #5)
> Steve, can you confirm whether or not anything still needs to land in master
> here for 1.2 hdpi support?
This bug only existed in hd branch because of a gallery hd patch has css bug, I already checked it and there is no need to land this in master.
Flags: needinfo?(schung)
Comment 7•11 years ago
|
||
[2013/10/21 Helix Testing]
Gaia: c829a2042594b6c3a4899ee27979799a0f301534
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID 20131015042201
Version 18.0
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•