Closed
Bug 881244
Opened 11 years ago
Closed 11 years ago
Port | Bug 878747 - browser.stop() call in addTab() is expensive and causes reflows | to SeaMonkey
Categories
(SeaMonkey :: Tabbed Browser, defect)
SeaMonkey
Tabbed Browser
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mz+bugzilla, Assigned: mz+bugzilla)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mz+bugzilla
:
review+
|
Details | Diff | Splinter Review |
Patch following
If I understand things correct...
Attachment #760397 -
Flags: review?(neil)
Comment 2•11 years ago
|
||
Comment on attachment 760397 [details] [diff] [review]
Almost copy-paste patch
The 'if (!blank)' check you removed is still needed.
Comment 3•11 years ago
|
||
Comment on attachment 760397 [details] [diff] [review]
Almost copy-paste patch
>+ if (!blank) {
>+ b.setAttribute("nodefaultsrc", "true");
>+ }
Nit: navigator style is to avoid {}s for a single line of code.
>- // Stop the existing about:blank load. Otherwise, if aURI
>- // doesn't stop in-progress loads on its own, we'll get into
>- // trouble with multiple parallel loads running at once.
>- b.stop();
Bug 716108 moved this line to its own block in Firefox which is why bug 878747 was able to simply remove that; the equivalent of the rest of the block still exists in Firefox inside an about blank check.
Attachment #760397 -
Flags: review?(neil) → review-
Updated•11 years ago
|
Assignee: nobody → pppx
Status: NEW → ASSIGNED
Hope this time I make proper patch
Attachment #760397 -
Attachment is obsolete: true
Attachment #763236 -
Flags: review?(neil)
Comment 5•11 years ago
|
||
Comment on attachment 763236 [details] [diff] [review]
Almost copy-paste patch v2
>+ if (!blank) {
>+ b.setAttribute("nodefaultsrc", "true");
>+ }
Lose the {}s please. r=me with that fixed.
Attachment #763236 -
Flags: review?(neil) → review+
Sorry, I saw that nit, but forget about it when remaking patch :(, fixed, carrying r+
Attachment #763236 -
Attachment is obsolete: true
Attachment #763274 -
Flags: review+
Keywords: checkin-needed
Comment 7•11 years ago
|
||
Sorry, I can't land this at the moment due to Seamonkey being closed from bug 870207. Callek says that things should be coming back soon and he'll take care of it then.
Keywords: checkin-needed
Whiteboard: checkin-suite-needed
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: checkin-suite-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•