Bug 857868 introduces a new test for storage quota notifications, which ensures the correct Preferences tab is opened when the notification is clicked on. That bug should gracefully detect when in-content prefs are enabled but will then hit some "todo" calls instead of actually checking the correct preference is visible. This bug is to track replacing these todo() calls in browser/base/content/test/browser_offlineQuotaNotification.js with appropriate checks.

In theory, the fix should be to replace the single todo call (there aren't multiple calls as I implied in comment 0) with: gBrowser.addEventListener("Initialized", function PrefInit() { gBrowser.removeEventListener("Initialized", PrefInit, true); checkPreferences(gBrowser.contentWindow); }, true);

Unassigned after triage, flagging as diamond. Markh, are you still willing to mentor this bug?

(In reply to Mike Hoye [:mhoye] from comment #2) > Unassigned after triage, flagging as diamond. Markh, are you still willing > to mentor this bug? Sure!

I think I can take this one. Seems a good thing to get back on track :)

Hernan, I think you should go for it.

I'm attaching a proposed patch for this, let me know if it needs polishing. Jared, Mark said to ask you for review as he never touched the new in-content preferences, but feel free to push it back to him.

Comment on attachment 8426809 [details] [diff] [review] proposed patch Review of attachment 8426809 [details] [diff] [review]: ----------------------------------------------------------------- This looks good. I double-checked that gBrowser.selectedBrowser would be OK to use right after clicking the popup notification's button. ::: browser/base/content/test/general/browser_offlineQuotaNotification.js @@ +36,5 @@ > }); > }); > } > +// Same as the other one, but for in-content preferences > +function checkIncontentPreferences(win) { nit, checkInContentPreferences (capital C) (here and below) @@ +42,5 @@ > + let doc = win.document; > + let tab = doc.getElementById("advancedPrefs").selectedTab.id; > + is(gBrowser.currentURI.spec, "about:preferences", "about:preferences loaded"); > + is(sel, "paneAdvanced", "Advanced pane was selected"); > + is(tab,"networkTab", "Network tab is selected"); nit, space after ','