Closed
Bug 881922
Opened 12 years ago
Closed 8 years ago
Broadway decoder clones small views of large buffers
Categories
(Web Compatibility :: Desktop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sfink, Unassigned)
References
()
Details
(Whiteboard: [country-us] [lib] [js] [sitewait])
Bug 789593 changed the implementation of structured clone to better match the spec. Previously, if you cloned a small view of a large buffer, only the data within the view would be copied. According to the spec, the full underlying ArrayBuffer should be cloned and a new view re-created. This makes the memory usage of the Broadway demo jump dramatically.
I have submitted a pull request for https://github.com/hotsphink/Broadway/commit/1c500d6700c89207c57d347941cc389710b0aa36 to address this issue.
Comment 1•10 years ago
|
||
The pull request is still open.
https://github.com/bkw/Broadway/pull/1
This is the only pull request being opened.
The last time the project was updated was September 1, 2013.
https://github.com/bkw/Broadway/commits/master
I'm just wondering if the pull request was done at the right place?
This seems to be the original project which is "more active". At least Feb 2014.
https://github.com/mbebenita/Broadway
https://github.com/mbebenita/Broadway/commits/master
What do you think Steve?
Assignee: english-us → nobody
Component: English US → Desktop
Flags: needinfo?(sphink)
Whiteboard: [country-us] [lib] [js] [sitewait]
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Karl Dubost :karlcow from comment #1)
> The pull request is still open.
> https://github.com/bkw/Broadway/pull/1
> This is the only pull request being opened.
>
> The last time the project was updated was September 1, 2013.
> https://github.com/bkw/Broadway/commits/master
>
> I'm just wondering if the pull request was done at the right place?
> This seems to be the original project which is "more active". At least Feb
> 2014.
> https://github.com/mbebenita/Broadway
> https://github.com/mbebenita/Broadway/commits/master
>
> What do you think Steve?
Thanks, looks plausible to me. After much futzing around, I believe I have made a proper update pull request: https://github.com/mbebenita/Broadway/pull/37 (I don't use git or github much, and it was very confusing.)
Flags: needinfo?(sphink)
Comment 3•8 years ago
|
||
That second PR was merged a few years back. Thanks Steve!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•6 years ago
|
Product: Tech Evangelism → Web Compatibility
You need to log in
before you can comment on or make changes to this bug.
Description
•